Skip to content

Update kube-api-linter version in README - #244

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
emirot:patch-1
May 5, 2026
Merged

Update kube-api-linter version in README#244
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
emirot:patch-1

Conversation

@emirot

@emirot emirot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Updated kube-api-linter version in README.

Why

The version currently present does not work

Stacktrace

$golangci-lint custom
WARN go: sigs.k8s.io/kube-api-linter@v0.0.0-20251029102002-9992248f8813: invalid pseudo-version: does not match version-control timestamp (expected 20251029172002) 
Error: build process: add to go.mod: go get sigs.k8s.io/kube-api-linter@v0.0.0-20251029102002-9992248f8813: exit status 1
The command is terminated due to an error: build process: add to go.mod: go get sigs.k8s.io/kube-api-linter@v0.0.0-20251029102002-9992248f8813: exit status 1

Replacing by latest here https://pkg.go.dev/sigs.k8s.io/kube-api-linter?tab=versions

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2026
@emirot

emirot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Please see my other PR #242 to fix CI

@JoelSpeed

Copy link
Copy Markdown
Contributor

I think the branch here will need to be rebased now

@emirot

emirot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

I think the branch here will need to be rebased now

Yes @JoelSpeed I just did

@JoelSpeed

Copy link
Copy Markdown
Contributor

@emirot Can you please do a rebase rather than merge commit and make this a single commit again?

@emirot
emirot force-pushed the patch-1 branch 2 times, most recently from fa6c5ee to e7e27df Compare April 27, 2026 17:40
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2026
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2026
@emirot

emirot commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

@emirot Can you please do a rebase rather than merge commit and make this a single commit again?

@JoelSpeed done!

@JoelSpeed

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emirot, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026
@k8s-ci-robot
k8s-ci-robot merged commit bc45f35 into kubernetes-sigs:main May 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants