Expand listType=set linter to disallow all non-scalars - #253
Merged
Conversation
kubernetes-prow
Bot
added
the
cncf-cla: yes
kubernetes-prow
Bot
added
approved
Contributor
Author
|
cc @JoelSpeed |
Contributor
Author
|
cc @liggitt |
JoelSpeed
reviewed
Jul 16, 2026
JoelSpeed
left a comment
JoelSpeed
left a comment
Contributor
There was a problem hiding this comment.
/lgtm
/approve
Sounds reasonable to me
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In kubernetes/kubernetes#140293 (review) it was noticed that CRDs allow listType=set for not only objects, but also slices and maps.
Due to the lack of SSA support, we would like to discourage use of non-scalar sets. We intend to ban the use for the native types in Kubernetes since none of the REST API types yet use non-scalar sets.