Skip to content

🐛 (go/v4): Add context import for incremental webhooks#5871

Open
immanuwell wants to merge 1 commit into
kubernetes-sigs:masterfrom
immanuwell:fix-webhook-context-import
Open

🐛 (go/v4): Add context import for incremental webhooks#5871
immanuwell wants to merge 1 commit into
kubernetes-sigs:masterfrom
immanuwell:fix-webhook-context-import

Conversation

@immanuwell

Copy link
Copy Markdown
Contributor

Fixes #5870

Adding admission webhooks after a conversion webhook missed the context import, so go build ./... failed. This adds it plus a regression test. Small gotcha, now all good

Repro:

kubebuilder init --domain example.org --repo example.com/demo
kubebuilder create api --group crew --version v1 --kind Charlie --resource --controller
kubebuilder create api --group crew --version v2 --kind Charlie --resource --controller=false
kubebuilder create webhook --group crew --version v1 --kind Charlie --conversion --spoke v2
kubebuilder create webhook --group crew --version v1 --kind Charlie --defaulting --programmatic-validation
go build ./...

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: immanuwell
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @immanuwell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 13, 2026
@@ -127,6 +127,7 @@ func (f *WebhookUpdater) SetTemplateDefaults() error {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an integration tests that cover all options regards webhook scaffolds so that we can ensure that it is working as we have no regression?

We should be able to add all possible combinations and the final result should pass in the make all and make lint. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

2 participants