🐛 (go/v4): Add context import for incremental webhooks#5871
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: immanuwell The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @immanuwell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -127,6 +127,7 @@ func (f *WebhookUpdater) SetTemplateDefaults() error { | |||
|
|
|||
There was a problem hiding this comment.
Could we add an integration tests that cover all options regards webhook scaffolds so that we can ensure that it is working as we have no regression?
We should be able to add all possible combinations and the final result should pass in the make all and make lint. WDYT?
Fixes #5870
Adding admission webhooks after a conversion webhook missed the
contextimport, sogo build ./...failed. This adds it plus a regression test. Small gotcha, now all goodRepro: