Fix non-linux builds of the kubemark cloud provider - #10148
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ribhavjain The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
This issue is currently awaiting triage. If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @ribhavjain! |
|
Hi @ribhavjain. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What type of PR is this?
/kind bug
What this PR does / why we need it:
go build ./...incluster-autoscalerfails on any non-linux platform:Commit abc6c70 ("Define provider name constants locally in each cloud provider package") defined
ProviderNameonly inkubemark_linux.go(build-taggedlinux), while the!linuxstub inkubemark_other.goreferences it ininit(). The stub already definesGPULabellocally, so this addsProviderNameto the same const block, matching the existing pattern.Verified:
go build ./...now passes on darwin and windows (kubemark package), and linux builds are unchanged.Which issue(s) this PR fixes:
None filed — hit while setting up a local development environment on macOS.
Special notes for your reviewer:
Per the contributor guide's AI guidance: AI tooling was used in preparing this change. I have reviewed it and can explain every line.
Does this PR introduce a user-facing change?