Removing noisy log for nodes not managed by CA. - #10157
Conversation
|
|
|
This issue is currently awaiting triage. If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @shreyshj. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shreyshj The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM |
What type of PR is this?
Bug Fix
What this PR does / why we need it:
A node pool that is not managed by CA , used to return the following log , which was misleading , changed the implementation slightly to supress noisy and incorrect logs.
LOG: Failed to check could provider has instance for 10.0.5.24: node pool not found for instance.
Which issue(s) this PR fixes:
For nodes not managed by CA , we now dont show logs node pool not found for instance , as the node pool is linked with instance , just that the nodepool is not managed by CA.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NO
For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md
-->
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: