Update Kubernetes dependencies to v1.36.1#9636
Conversation
k8s-ci-robot
added
release-note
|
This issue is currently awaiting triage. If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
do-not-merge/needs-area
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Jack Francis <jackfrancis@gmail.com>
jackfrancis
force-pushed
the
k8s-deps-v1.36.1
branch
from
e3547fa to
f228157
Compare
jackfrancis
removed
area/provider/azure
|
/retitle Update Kubernetes dependencies to v1.36.1 |
k8s-ci-robot
changed the title
|
/test pull-cluster-autoscaler-e2e-azure-master |
| # Use -i.bak for portability: BSD sed (macOS) requires an explicit backup | ||
| # extension argument to -i, while GNU sed accepts it as well. -E enables | ||
| # extended regex on both BSD and GNU sed. | ||
| "${SED}" -E -i.bak 's/const ClusterAutoscalerVersion = "[0-9.]+"/const ClusterAutoscalerVersion = "'${k8s_version}'"/g' version/version.go |
There was a problem hiding this comment.
Since we are not aligned with k/k patch version, only minor, do we actually want this part at all? Dynamically providing this value at build time based on git tag sounds more like what we should be doing instead.
There was a problem hiding this comment.
It's a good call-out. Right now I use this (incorrect) change to remind me to (manually) update the value to match the n + 1 of the upcoming CA release.
The challenge with relying upon commit tags means that there is a tight coupling between making automated changes to the k8s dependency graph and the resultant commit being releasable.
Maybe you are suggesting that we drop this version.go update entirely in this script? I might agree w/ you.
Thoughts @BigDarkClown @towca ?
There was a problem hiding this comment.
I felt like I had this idea before and indeed - about a year ago :D #8240
There was a problem hiding this comment.
Btw, for not tagged commits the version should ideally contain git commit hash (with -dirty suffix if there were uncommited changes), which might also help with regular development.
5 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR brings in the latest Kubernetes v1.36 libraries in preparation for a Cluster Autoscaler v1.36.0 release.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: