[manila-csi-plugin] Remove rules from aggregated ClusterRoles to fix Helm v4 SSA conflict

[carterpewpew]

What this PR does / why we need it:

When a ClusterRole uses aggregationRule, the clusterrole-aggregation-controller takes SSA ownership of the .rules field. The chart currently renders rules: [] on both the controllerplugin and nodeplugin aggregated ClusterRoles. With Helm v4 (which defaults to Server-Side Apply), this causes a field manager conflict on every helm upgrade after the initial install, because both Helm and the aggregation controller claim ownership of .rules. This PR removes the redundant rules: [] from both templates. The aggregation controller continues to populate the rules from the matching child ClusterRoles as before.

Which issue this PR fixes(if applicable):
fixes #3119

Special notes for reviewers:

Release note:

[manila-csi-plugin] Fixed Helm v4 upgrade failure caused by SSA conflict on aggregated ClusterRoles.

[k8s-ci-robot]

Hi @carterpewpew. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gouthampacha]

/ok-to-test

[gouthampacha]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gouthampacha
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gouthampacha]

The lint CI failure is because ct lint requires a version bump when chart files change:

Old chart version: 2.36.0
New chart version: 2.36.0
✖︎ openstack-manila-csi => chart version not ok. Needs a version bump!

Please bump the version in charts/manila-csi-plugin/Chart.yaml (e.g. 2.36.0 → 2.36.1).

[kubernetes-prow]

New changes are detected. LGTM label has been removed.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gouthampacha
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[carterpewpew]

The lint CI failure is because ct lint requires a version bump when chart files change:

Old chart version: 2.36.0
New chart version: 2.36.0
✖︎ openstack-manila-csi => chart version not ok. Needs a version bump!

Please bump the version in charts/manila-csi-plugin/Chart.yaml (e.g. 2.36.0 → 2.36.1).

Bumped the chart version to 2.36.1 in Chart.yaml to fix the ct lint failure. The CI should pass now. @gouthampacha PTAL. Thanks for taking a look again.

[gouthampacha]

/retest-required