[manila-csi-plugin] Allow shareAccessID and shareAccessIDs to coexist#3132
[manila-csi-plugin] Allow shareAccessID and shareAccessIDs to coexist#3132gouthampacha wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest-required |
|
@gouthampacha: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Remove the precludes relationship between shareAccessID and shareAccessIDs so that both parameters can be set simultaneously. When both are present, shareAccessIDs takes precedence (existing behavior in getAccessIDs). This restores backwards compatibility for consumers that set both fields during migration from the deprecated shareAccessID to shareAccessIDs. Fixes: kubernetes#3131
1431f87 to
eefd638
Compare
What this PR does / why we need it:
Removes the
precludesrelationship betweenshareAccessIDandshareAccessIDsinNodeVolumeContextso both parameters can be set simultaneously. When both are present,shareAccessIDstakes precedence (existing behavior ingetAccessIDs()). This restores backwards compatibility for consumers migrating from the deprecatedshareAccessIDtoshareAccessIDs.Which issue this PR fixes:
Fixes #3131
Special notes for reviewers:
The only production code change is in
pkg/csi/manila/options/shareoptions.go— two struct tags changed fromprecludes/optionalIfto plainoptional. The precedence logic ingetAccessIDs()already handles the case where both are set.Release note: