Skip to content

[manila-csi-plugin] Allow shareAccessID and shareAccessIDs to coexist#3132

Open
gouthampacha wants to merge 1 commit into
kubernetes:masterfrom
gouthampacha:worktree-fix-share-access-id-precludes
Open

[manila-csi-plugin] Allow shareAccessID and shareAccessIDs to coexist#3132
gouthampacha wants to merge 1 commit into
kubernetes:masterfrom
gouthampacha:worktree-fix-share-access-id-precludes

Conversation

@gouthampacha

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Removes the precludes relationship between shareAccessID and shareAccessIDs in NodeVolumeContext so both parameters can be set simultaneously. When both are present, shareAccessIDs takes precedence (existing behavior in getAccessIDs()). This restores backwards compatibility for consumers migrating from the deprecated shareAccessID to shareAccessIDs.

Which issue this PR fixes:
Fixes #3131

Special notes for reviewers:

The only production code change is in pkg/csi/manila/options/shareoptions.go — two struct tags changed from precludes/optionalIf to plain optional. The precedence logic in getAccessIDs() already handles the case where both are set.

Release note:

[manila-csi-plugin] Allow shareAccessID and shareAccessIDs to be set simultaneously for backwards compatibility. shareAccessIDs takes precedence when both are present.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 19, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gouthampacha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from Fedosin and tsmetana June 19, 2026 19:49
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2026
@gouthampacha

Copy link
Copy Markdown
Contributor Author

/retest-required

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@gouthampacha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-openstack-check 5e7ad0b link true /test pull-cloud-provider-openstack-check

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gouthampacha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Remove the precludes relationship between shareAccessID and
shareAccessIDs so that both parameters can be set simultaneously.
When both are present, shareAccessIDs takes precedence (existing
behavior in getAccessIDs). This restores backwards compatibility
for consumers that set both fields during migration from the
deprecated shareAccessID to shareAccessIDs.

Fixes: kubernetes#3131
@gouthampacha gouthampacha force-pushed the worktree-fix-share-access-id-precludes branch from 1431f87 to eefd638 Compare June 23, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing backwards compatibility for optional "ShareAccessID"

2 participants