Skip to content

Remove Disruptive tests tag from e2e documentation#9018

Open
SergeyKanzhelev wants to merge 1 commit into
kubernetes:mainfrom
SergeyKanzhelev:task-remove-disruptive-tests-docs-a1b2
Open

Remove Disruptive tests tag from e2e documentation#9018
SergeyKanzhelev wants to merge 1 commit into
kubernetes:mainfrom
SergeyKanzhelev:task-remove-disruptive-tests-docs-a1b2

Conversation

@SergeyKanzhelev

Copy link
Copy Markdown
Member

Discussed before: kubernetes/kubernetes#135142 (comment)

Let's remove the Disruptive tag. It feels unnecessary as discussed kubernetes/kubernetes#135142 (comment). As far as I know nobody runs disruptive tests one-per-environment. So the Serial already covers the fact that the test should not run with others

/cc @pohly

/sig testing

@k8s-ci-robot k8s-ci-robot requested a review from pohly June 9, 2026 00:07
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 9, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please assign pohly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/developer-guide Issues or PRs related to the developer guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2026
@pohly

pohly commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

In kubernetes/kubernetes#135142 (comment), @BenTheElder explained why "Disruptive" can be useful: someone running tests against an existing, in-use cluster may want to filter out "disruptive" tests to avoid affecting the normal workload in the cluster. We don't need this in any of our Prow jobs because those are specifically for running tests, so "disruptive" is acceptable. We rely on "serial" instead to manage interference between tests.

Someone running "serial" tests in an in-use cluster may have to be prepared for additional flakiness because one reason for "serial" can be "this tests must not be disturbed", but at least the tests won't break anything else.

"disruptive" implies "serial" (i.e. both must be set), but not the other way around.

I would keep "disruptive".

@SergeyKanzhelev

Copy link
Copy Markdown
Member Author

@BenTheElder how much do you think it is important to keep the informational "Disruptive" tag? Most serial jobs will break if any other activity is happening on the node. So all of them are "Disrupted". Not all Serial will Disrupt other workload, but in most cases they will. So it is really not that informative to have the "Disruptive" tag. I would think following this up with adding a human-readable note to "Serial" tag that explains why it is serial will help more than having a Disruptive tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants