feat: use path field from keps.json for KEP README URLs - #804
Open
TineoC wants to merge 3 commits into
Open
Conversation
kubernetes-prow
Bot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TineoC The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
approved
Contributor
Author
|
/hold until k/enhancements PR is approved |
kubernetes-prow
Bot
added
the
do-not-merge/hold
kubernetes-prow
Bot
added
the
language/en
TineoC
force-pushed
the
fix/kep-use-directory-field
branch
from
July 14, 2026 16:39
98836d3 to
675c712
Compare
TineoC
changed the title
TineoC
force-pushed
the
fix/kep-use-directory-field
branch
from
July 14, 2026 16:43
675c712 to
de7f924
Compare
Contributor
Author
|
/retest all |
Contributor
|
@TineoC: No presubmit jobs available for kubernetes/contributor-site@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/unhold |
kubernetes-prow
Bot
removed
the
do-not-merge/hold
Contributor
Author
Member
kubernetes-prow
Bot
added
the
do-not-merge/hold
kubernetes-prow
Bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefers
pathfield fromkeps.jsonoverowningSig/namefor README URLs.Also fixes two bugs where the fallback
README.MDURL and relative link/image path resolution still used the oldowningSig/namepattern instead of$kepPath— these were broken for nested KEPs (depth 3+ paths likesig-cloud-provider/azure/2328-ccm-instance-metadata).Depends on: kubernetes/enhancements#6225
Pages to test:
Verify these render correctly on the deploy preview:
sig-api-machinery/1040-priority-and-fairnesssig-cloud-provider/azure/2328-ccm-instance-metadatasig-cluster-lifecycle/kubeadm/2500-kubeadm-join-control-plane-workflowsig-cloud-provider/azure/586-azure-availability-zonessig-cloud-provider/azure/667-out-of-tree-azureNote: Maximum nesting depth in
keps.jsonis 3 (sig/subdir/kep-name). No depth 4+ KEPs exist in the current data.Deploy preview: https://deploy-preview-804--kubernetes-contributor.netlify.app