Skip to content

Add markdownlint CI for blog posts - #806

Open
TineoC wants to merge 3 commits into
kubernetes:mainfrom
TineoC:chore/add-markdownlint-blog-ci
Open

Add markdownlint CI for blog posts#806
TineoC wants to merge 3 commits into
kubernetes:mainfrom
TineoC:chore/add-markdownlint-blog-ci

Conversation

@TineoC

@TineoC TineoC commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Run markdownlint on new/modified blog posts in any language during pull requests.

Refs: kubernetes/website#54795

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TineoC

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@kubernetes-prow kubernetes-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 26, 2026
@TineoC

TineoC commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

/hold

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2026
@TineoC
TineoC force-pushed the chore/add-markdownlint-blog-ci branch from 7accfee to 33d30a5 Compare July 1, 2026 10:39
@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2026
@TineoC

TineoC commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author
=== PR #796 — Draft: Add blog editor onboarding guide ===
stdin:73 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
stdin:116:17 error MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
stdin:131 error MD036/no-emphasis-as-heading Emphasis used instead of a heading [Context: "ALWAYS CHECK ON MOBILE TOO"]
stdin:168:39 error MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
stdin:191:19 error MD026/no-trailing-punctuation Trailing punctuation in heading [Punctuation: '!']
stdin:221 error MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
stdin:223:21 error MD047/single-trailing-newline Files should end with a single newline character

=== PR #795 — Draft: KCD NY ===
stdin:17 error MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
stdin:18:13 error MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
stdin:18 error MD022/blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Picture-1"]
stdin:21:13 error MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
stdin:21 error MD022/blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Picture-2"]
stdin:24 error MD022/blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Picture-3"]

- Extract inline CI logic into hack/lint-blogs.sh script
- Add lint-blogs and print-node-version Makefile targets
- Convert .markdownlint.json to .markdownlint.jsonc with inline comments
- Disable MD060 table column style rule
- Add markdownlint-cli dev dependency
- Read NODE_VERSION from netlify.toml instead of hardcoding
@TineoC
TineoC force-pushed the chore/add-markdownlint-blog-ci branch from d7408db to 8691015 Compare July 1, 2026 10:59
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2026
@TineoC

TineoC commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

/unhold

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2026
@TineoC

TineoC commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@jberkus @lmktfy

if this is too invasive, do you think setting up these rules as warnings on the CI Checks would be better?

To not block blogs from being published as we try this tool

CI passes LINT_BLOGS_WARN_ONLY=1 so findings show as GitHub warning
annotations and do not fail the check, allowing maintainers to merge.
Local make lint-blogs still fails by default.
@kubernetes-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant