Skip to content

fix: keep KEP detail card columns balanced - #838

Open
TusharChauhan09 wants to merge 3 commits into
kubernetes:mainfrom
TusharChauhan09:fix-kep-detail-card-width
Open

fix: keep KEP detail card columns balanced#838
TusharChauhan09 wants to merge 3 commits into
kubernetes:mainfrom
TusharChauhan09:fix-kep-detail-card-width

Conversation

@TusharChauhan09

@TusharChauhan09 TusharChauhan09 commented Aug 5, 2026

Copy link
Copy Markdown

Fixes uneven column widths in the KEP detail metadata card. Closes: #837

The KEP metadata banner uses a two-column CSS grid, but long content in the "Related Enhancements" section could influence the intrinsic size of the first column. As a result, the Implementation History column expanded while the Ownership column became noticeably narrower, making the card look unbalanced on desktop and medium-sized screens.

CSS only, scoped to .kep-page in assets/scss/_kep_page.scss. No markup or content changes.

Changes:

  • Use minmax(0, 1fr) for the metadata banner grid so both columns share the available width evenly.
  • Allow banner columns to shrink correctly by adding min-width: 0.
  • Allow long Related Enhancement links to wrap naturally using overflow-wrap: anywhere.
  • Replace the flex layout for Related Enhancement links with a block layout so wrapped links no longer affect the column width calculation.
  • Keep the leading icon aligned by replacing flex-shrink with a right margin.

Verified locally with the pinned Hugo v0.144.2 (make container-server). The KEP pages build successfully and the metadata banner maintains balanced columns.

Before

KEP detail card before fix — uneven columns, long URLs overflow into Ownership column

After

KEP detail card after fix — balanced columns, URLs wrap in left column

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 5, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: TusharChauhan09 / name: TusharChauhan09 (a422f0f)

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @TusharChauhan09!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 5, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from jberkus and jeefy August 5, 2026 14:44
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TusharChauhan09
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 5, 2026
font-size: 0.85rem;
color: $slate-700;
text-decoration: none;
display: flex;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is possible to fix it keeping the flex display?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, kept display: flex on the link items and fixed the alignment with some other flex properties instead. Pushed the latest commits, let me know if it looks good now

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one more issue - long URLs were still overflowing with display : flex. So I kept it like you asked, just wrapped the URL text in a span so it could actually shrink and wrap

@TusharChauhan09
TusharChauhan09 force-pushed the fix-kep-detail-card-width branch from a422f0f to 5311017 Compare August 7, 2026 14:58
@kubernetes-prow kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2026
@kubernetes-prow kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

style: kep detail card overflow

2 participants