fix: keep KEP detail card columns balanced - #838
Conversation
|
|
|
Welcome @TusharChauhan09! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TusharChauhan09 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| font-size: 0.85rem; | ||
| color: $slate-700; | ||
| text-decoration: none; | ||
| display: flex; |
There was a problem hiding this comment.
is possible to fix it keeping the flex display?
There was a problem hiding this comment.
Yeah, kept display: flex on the link items and fixed the alignment with some other flex properties instead. Pushed the latest commits, let me know if it looks good now
There was a problem hiding this comment.
found one more issue - long URLs were still overflowing with display : flex. So I kept it like you asked, just wrapped the URL text in a span so it could actually shrink and wrap
a422f0f to
5311017
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes uneven column widths in the KEP detail metadata card. Closes: #837
The KEP metadata banner uses a two-column CSS grid, but long content in the "Related Enhancements" section could influence the intrinsic size of the first column. As a result, the Implementation History column expanded while the Ownership column became noticeably narrower, making the card look unbalanced on desktop and medium-sized screens.
CSS only, scoped to
.kep-pageinassets/scss/_kep_page.scss. No markup or content changes.Changes:
minmax(0, 1fr)for the metadata banner grid so both columns share the available width evenly.min-width: 0.overflow-wrap: anywhere.flex-shrinkwith a right margin.Verified locally with the pinned Hugo v0.144.2 (
make container-server). The KEP pages build successfully and the metadata banner maintains balanced columns.https://deploy-preview-838--kubernetes-contributor.netlify.app/resources/keps/6060/
Before
After