Enable dark mode - #846
Open
Madhurchandran wants to merge 2 commits into
Open
Conversation
kubernetes-prow
Bot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Madhurchandran The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
size/L
feat: resolve community groups dark mode regressions feat(theme): resolve dark mode DataTables regressions feat: improve dark mode theme toggle visibility feat: improve KEP dark mode styling and organize styles feat: replace remaining hardcoded colors with CSS vars across all SCSS files feat: refine KEP table dark mode styles feat: address review comments feat: address review feedback feat:Improve Community Groups dark theme readability feat: refine dark mode component styling
Madhurchandran
force-pushed
the
enable-dark-mode
branch
from
August 9, 2026 20:53
6cca225 to
a65aef0
Compare
Contributor
Author
|
Hey @TineoC, I’ve been working through the dark mode PR and have done some cleanup to reduce unnecessary overrides and !important occurrences. What approach would you recommend for the remaining hardcoded colors? |
Contributor
|
/hold Until the RSS errors are resolved |
kubernetes-prow
Bot
added
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable dark-mode styling across the contributor site and fixes several visual regressions found while testing the KEP and Community Groups pages.
Changes
Remaining work
!importantusage.Testing
Related
Ref: #745
AI Disclosure
An AI assistant was used to help identify and fix issues during regression testing. All changes were reviewed and validated before submission.