fix(keps): point markdown links to GitHub blob view instead of raw - #856
Open
Madhurchandran wants to merge 2 commits into
Open
fix(keps): point markdown links to GitHub blob view instead of raw#856Madhurchandran wants to merge 2 commits into
Madhurchandran wants to merge 2 commits into
Conversation
kubernetes-prow
Bot
added
cncf-cla: yes
kubernetes-prow
Bot
added
the
language/en
Member
|
/assign @TineoC for review. |
TineoC
reviewed
Aug 13, 2026
| @@ -108,15 +108,17 @@ | |||
| {{- /* Fix relative image and link paths to point to GitHub */ -}} | |||
| {{- $repoBaseUrl := "https://raw.githubusercontent.com/kubernetes/enhancements/master/" -}} | |||
Contributor
There was a problem hiding this comment.
is this being unused with this implementation?
Contributor
Author
There was a problem hiding this comment.
@TineoC I’ve addressed this in the latest commit by splitting the raw and blob URLs and updating the variable names as suggested in the issue.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Madhurchandran The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes an issue where links inside rendered KEPs point to raw.githubusercontent.com, causing them to display unrendered ra Markdown instead of the rendered GitHub page.
Changes:
Fixes:
#848