Skip to content

Reapply "Modernize codegen in hack/update-codegen.sh"#2982

Open
bowei wants to merge 4 commits intokubernetes:masterfrom
bowei:pr-modernize-codegen
Open

Reapply "Modernize codegen in hack/update-codegen.sh"#2982
bowei wants to merge 4 commits intokubernetes:masterfrom
bowei:pr-modernize-codegen

Conversation

@bowei
Copy link
Copy Markdown
Member

@bowei bowei commented Sep 11, 2025

This reverts commit 5afb60b.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 11, 2025
swetharepakula
swetharepakula reviewed Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bowei,swetharepakula]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bowei
Copy link
Copy Markdown
Member Author

bowei commented Sep 30, 2025

/test

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 30, 2025

@bowei: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-ingress-gce-e2e

/test pull-ingress-gce-test

/test pull-ingress-gce-verify

Use /test all to run all jobs.

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bowei
Copy link
Copy Markdown
Member Author

bowei commented Sep 30, 2025

/test pull-ingress-gce-verify

@bowei bowei force-pushed the pr-modernize-codegen branch from 9645234 to 7fb04c8 Compare September 30, 2025 18:58
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 30, 2025

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025
@bowei bowei force-pushed the pr-modernize-codegen branch from 381492c to c9162d0 Compare December 8, 2025 22:50
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 8, 2025

@bowei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress-gce-verify c9162d0 link true /test pull-ingress-gce-verify
pull-ingress-gce-test c9162d0 link true /test pull-ingress-gce-test
pull-ingress-gce-e2e c9162d0 link true /test pull-ingress-gce-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 3, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TortillaZHawaii
Copy link
Copy Markdown
Member

TortillaZHawaii commented Jan 12, 2026

fyi #3034 has also modified codegen

and also #3029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swetharepakula swetharepakula swetharepakula left review comments

@aojea aojea Awaiting requested review from aojea

@sawsa307 sawsa307 Awaiting requested review from sawsa307

Assignees

@swetharepakula swetharepakula

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bowei @k8s-ci-robot @TortillaZHawaii @swetharepakula