refactor: update informer set to use SharedInformerFactory for GKE Networking API and core Kubernetes resources.#3060
Conversation
…tworking API and core Kubernetes resources.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iromanycheva-eng The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @iromanycheva-eng! |
|
Hi @iromanycheva-eng. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…tworking API and core Kubernetes resources.
…tworking API and core Kubernetes resources.
|
/ok-to-test |
|
/cc @swetharepakula , please review the change. |
|
/assign @swetharepakula |
| resyncPeriod.Duration, | ||
| utils.NewNamespaceIndexer(), | ||
| ) | ||
| // Create core Kubernetes informers from factory |
There was a problem hiding this comment.
for all of the informers we create, set the namespace indexer on them
swetharepakula
left a comment
There was a problem hiding this comment.
This change mostly looks good to me.
A couple of comments, to add back the namespace indexer for the informers.
For the commits, can you squash them. If you would like to keep each commit separate, then update the messages to indicate what each commit is doing. Also can you separate out the vendor and the go.mod changes. I would make that the first commit and then have the code changes after that.
Refactor InformerSet to use component SharedInformerFactory instead of handling each Informer individually.
This change is aligned with standard controller idiomatic patterns.