Skip to content

refactor: update informer set to use SharedInformerFactory for GKE Networking API and core Kubernetes resources.#3060

Open
iromanycheva-eng wants to merge 3 commits intokubernetes:masterfrom
iromanycheva-eng:master
Open

refactor: update informer set to use SharedInformerFactory for GKE Networking API and core Kubernetes resources.#3060
iromanycheva-eng wants to merge 3 commits intokubernetes:masterfrom
iromanycheva-eng:master

Conversation

@iromanycheva-eng
Copy link
Copy Markdown

Refactor InformerSet to use component SharedInformerFactory instead of handling each Informer individually.
This change is aligned with standard controller idiomatic patterns.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iromanycheva-eng
Once this PR has been reviewed and has the lgtm label, please assign mmamczur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 13, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @iromanycheva-eng!

It looks like this is your first PR to kubernetes/ingress-gce 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-gce has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @iromanycheva-eng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 13, 2026
@TortillaZHawaii
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2026
@iromanycheva-eng
Copy link
Copy Markdown
Author

iromanycheva-eng commented Mar 13, 2026

/cc @swetharepakula , please review the change.

@iromanycheva-eng
Copy link
Copy Markdown
Author

/assign @swetharepakula

resyncPeriod.Duration,
utils.NewNamespaceIndexer(),
)
// Create core Kubernetes informers from factory
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all of the informers we create, set the namespace indexer on them

Copy link
Copy Markdown
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change mostly looks good to me.

A couple of comments, to add back the namespace indexer for the informers.

For the commits, can you squash them. If you would like to keep each commit separate, then update the messages to indicate what each commit is doing. Also can you separate out the vendor and the go.mod changes. I would make that the first commit and then have the code changes after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants