Skip to content

Use protobuf#18068

Open
serathius wants to merge 1 commit intokubernetes:masterfrom
serathius:protobuf
Open

Use protobuf#18068
serathius wants to merge 1 commit intokubernetes:masterfrom
serathius:protobuf

Conversation

@serathius
Copy link
Copy Markdown
Contributor

@serathius serathius commented Mar 14, 2026 •
edited
Loading

Experimenting with fixing kops validate cluster --wait not working for large cluster #18065

First rule of K8s, always use protobuf

@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab March 14, 2026 09:28
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2026
@justinsb
Copy link
Copy Markdown
Member

justinsb commented Mar 14, 2026

/test pull-kops-e2e-k8s-aws-amazonvpc

The other two look like a bug (we should never segfault!). I'll see if I can understand why we are segfaulting!

@serathius serathius force-pushed the protobuf branch 2 times, most recently from 50d7090 to d9f6b79 Compare March 14, 2026 12:15
@justinsb justinsb mentioned this pull request Mar 14, 2026
Merged
@justinsb
Copy link
Copy Markdown
Member

justinsb commented Mar 14, 2026

The bare-metal flakes should be fixed by #18072 (which has merged, so you need to rebase because that is a Github Action test)

justinsb
justinsb reviewed Mar 14, 2026
View reviewed changes
cmd/kops/util/factory.go
restConfig.UserAgent = "kops"
restConfig.Burst = 50
restConfig.QPS = 20
restConfig.AcceptContentTypes = runtime.ContentTypeProtobuf
Copy link
Copy Markdown
Member

@justinsb justinsb Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but should we specify a list (e.g. proto then json)? I thought the server was only allowed to send a type that was in the Accept header?

Copy link
Copy Markdown
Contributor Author

@serathius serathius Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect it would be more compliant with HTTP standard, however it will work with K8s API Server as it will fallback itself to JSON.

@serathius
Copy link
Copy Markdown
Contributor Author

serathius commented Mar 14, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb justinsb left review comments

@hakman hakman Awaiting requested review from hakman

@zetaab zetaab Awaiting requested review from zetaab

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serathius @k8s-ci-robot @justinsb