Skip to content

fix: persist binariesLocation for AWS and GCE in v1alpha2 - #18740

Open
madhoshyagnik wants to merge 1 commit into
kubernetes:masterfrom
madhoshyagnik:fix-binaries-location-18736
Open

fix: persist binariesLocation for AWS and GCE in v1alpha2#18740
madhoshyagnik wants to merge 1 commit into
kubernetes:masterfrom
madhoshyagnik:fix-binaries-location-18736

Conversation

@madhoshyagnik

Copy link
Copy Markdown

What this PR does / why we need it:

Fixes #18736.

spec.cloudProvider.aws.binariesLocation and spec.cloudProvider.gce.binariesLocation existed in the internal API and v1alpha3, but lacked a representation in the v1alpha2 API.
Because kOps persists cluster specs to the state store in the v1alpha2 format, these fields were silently dropped on every write, making them unreachable in standard workflows.

This PR adds AWSBinariesLocation and GCEBinariesLocation to the CloudConfiguration struct in pkg/apis/kops/v1alpha2/componentconfig.go (next to other AWS/GCE-specific settings like DisableSecurityGroupIngress and GCEUseStartupScript). It also includes the necessary manual conversions in pkg/apis/kops/v1alpha2/conversion.go to ensure BinariesLocation successfully round-trips to and from the internal CloudProvider struct.

Which issue(s) this PR fixes:

Fixes #18736

Special notes for your reviewer:

Ran make apimachinery to regenerate conversions and deepcopies.

@kubernetes-prow kubernetes-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 23, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @madhoshyagnik!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @madhoshyagnik. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Adds AWSBinariesLocation and GCEBinariesLocation to CloudConfiguration in v1alpha2
and wires up conversions so that BinariesLocation does not get dropped when
the cluster spec is written to the state store as v1alpha2.
@madhoshyagnik
madhoshyagnik force-pushed the fix-binaries-location-18736 branch from 9094a48 to 99083a8 Compare August 23, 2026 20:13
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 23, 2026
@madhoshyagnik
madhoshyagnik marked this pull request as ready for review August 23, 2026 20:14
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from olemarkus August 23, 2026 20:15
@ameukam

ameukam commented Aug 24, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2026
@ameukam

ameukam commented Aug 24, 2026

Copy link
Copy Markdown
Member

@hakman do we want to keep parity of alpha2with alpha3 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cloudProvider.{aws,gce}.binariesLocation has no v1alpha2 representation and is silently dropped

2 participants