fix: persist binariesLocation for AWS and GCE in v1alpha2 - #18740
fix: persist binariesLocation for AWS and GCE in v1alpha2#18740madhoshyagnik wants to merge 1 commit into
Conversation
|
Welcome @madhoshyagnik! |
|
Hi @madhoshyagnik. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Adds AWSBinariesLocation and GCEBinariesLocation to CloudConfiguration in v1alpha2 and wires up conversions so that BinariesLocation does not get dropped when the cluster spec is written to the state store as v1alpha2.
9094a48 to
99083a8
Compare
|
/ok-to-test |
|
@hakman do we want to keep parity of |
What this PR does / why we need it:
Fixes #18736.
spec.cloudProvider.aws.binariesLocationandspec.cloudProvider.gce.binariesLocationexisted in the internal API andv1alpha3, but lacked a representation in thev1alpha2API.Because kOps persists cluster specs to the state store in the
v1alpha2format, these fields were silently dropped on every write, making them unreachable in standard workflows.This PR adds
AWSBinariesLocationandGCEBinariesLocationto theCloudConfigurationstruct inpkg/apis/kops/v1alpha2/componentconfig.go(next to other AWS/GCE-specific settings likeDisableSecurityGroupIngressandGCEUseStartupScript). It also includes the necessary manual conversions inpkg/apis/kops/v1alpha2/conversion.goto ensureBinariesLocationsuccessfully round-trips to and from the internalCloudProviderstruct.Which issue(s) this PR fixes:
Fixes #18736
Special notes for your reviewer:
Ran
make apimachineryto regenerate conversions and deepcopies.