Update hyperkit to note deprecation, note Apple Silicon hypervisor alternatives#23027
Conversation
… on Apple Silicon Point at the current hypervisor options for Apple Silicon with a warning message at the top of the hyperkit driver page.
|
Welcome @vielmetti! |
|
Hi @vielmetti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
nirs
left a comment
There was a problem hiding this comment.
@vielmetti Thanks, this looks like a good minimal change before we remove the driver.
rearrange order of alternative suggestions for hyperkit, putting vfkit as the preference.
|
updated as requested, I think I got the ref syntax right |
tidy up punctuation
|
@vielmetti You got the link syntax right - you can see the preview: However GitHub alerts are not supported in the docs - the pages are not rendered by GitHub. We have another syntax for warnings - you can find it in other docs. Example warning: I think the warning should be first on the page - before the overview. |
This should now look like the intended "warning" overview, without a spurious second indentation.
|
@prezha I think this is ready for your review - take a look at https://deploy-preview-23027--kubernetes-sigs-minikube.netlify.app/docs/drivers/hyperkit/ for the preview |
|
Nobody had any concern in the last 3 days. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirs, vielmetti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Testing is not require for docs only change but the workflows are not configured correctly. /ok-to-test |
|
@vielmetti: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Point at the current hypervisor options for Apple Silicon with a warning message at the top of the hyperkit driver page.
fixes #23005
Even if the feature is deprecated the codebase is still there for it; there are other open issues targeting removal of this code. First step is to correctly set expectations for lack of support.
Preview: https://deploy-preview-23027--kubernetes-sigs-minikube.netlify.app/docs/drivers/hyperkit/