Skip to content

Update hyperkit to note deprecation, note Apple Silicon hypervisor alternatives#23027

Merged
k8s-ci-robot merged 5 commits into
kubernetes:masterfrom
vielmetti:patch-1
Jun 4, 2026
Merged

Update hyperkit to note deprecation, note Apple Silicon hypervisor alternatives#23027
k8s-ci-robot merged 5 commits into
kubernetes:masterfrom
vielmetti:patch-1

Conversation

@vielmetti

@vielmetti vielmetti commented May 23, 2026

Copy link
Copy Markdown
Contributor

Point at the current hypervisor options for Apple Silicon with a warning message at the top of the hyperkit driver page.

fixes #23005

Even if the feature is deprecated the codebase is still there for it; there are other open issues targeting removal of this code. First step is to correctly set expectations for lack of support.

Preview: https://deploy-preview-23027--kubernetes-sigs-minikube.netlify.app/docs/drivers/hyperkit/

… on Apple Silicon

Point at the current hypervisor options for Apple Silicon with a warning message at the top of the hyperkit driver page.
@k8s-ci-robot k8s-ci-robot requested review from nirs and prezha May 23, 2026 03:27
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @vielmetti!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @vielmetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 23, 2026
@minikube-bot

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@nirs nirs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vielmetti Thanks, this looks like a good minimal change before we remove the driver.

Comment thread site/content/en/docs/drivers/hyperkit.md Outdated
@nirs nirs added kind/documentation Categorizes issue or PR as related to documentation. co/hyperkit Hyperkit related issues labels May 23, 2026
@nirs nirs added this to the minikube v1.39 milestone May 23, 2026
rearrange order of alternative suggestions for hyperkit, putting vfkit as the preference.
@vielmetti

Copy link
Copy Markdown
Contributor Author

updated as requested, I think I got the ref syntax right

tidy up punctuation
@nirs

nirs commented May 29, 2026

Copy link
Copy Markdown
Collaborator

@vielmetti You got the link syntax right - you can see the preview:
https://deploy-preview-23027--kubernetes-sigs-minikube.netlify.app/docs/drivers/hyperkit/

However GitHub alerts are not supported in the docs - the pages are not rendered by GitHub. We have another syntax for warnings - you can find it in other docs.

Example warning:

{{% alert title="Warning" color="warning" %}}
Warning text...
{{% /alert %}}

I think the warning should be first on the page - before the overview.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2026
This should now look like the intended "warning" overview, without a spurious second indentation.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2026

@nirs nirs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2026
@vielmetti

Copy link
Copy Markdown
Contributor Author

@prezha I think this is ready for your review - take a look at https://deploy-preview-23027--kubernetes-sigs-minikube.netlify.app/docs/drivers/hyperkit/ for the preview

@nirs

nirs commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Nobody had any concern in the last 3 days.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirs, vielmetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nirs

nirs commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Testing is not require for docs only change but the workflows are not configured correctly.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@vielmetti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-docker-crio-linux-x86 d6f2133 link false /test pull-minikube-docker-crio-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 6a7249d into kubernetes:master Jun 4, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. co/hyperkit Hyperkit related issues kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hyperkit "Warning: hyperkit has been deprecated because it is not maintained upstream! It was disabled on 2025-06-21."

4 participants