Skip to content

Fix --extra-config=etcd.* producing invalid kubeadm config#23051

Open
noamcohen97 wants to merge 1 commit into
kubernetes:masterfrom
noamcohen97:fix-v1beta4-etcd-extraargs-newline
Open

Fix --extra-config=etcd.* producing invalid kubeadm config#23051
noamcohen97 wants to merge 1 commit into
kubernetes:masterfrom
noamcohen97:fix-v1beta4-etcd-extraargs-newline

Conversation

@noamcohen97
Copy link
Copy Markdown

TestGenerateKubeadmYAML now verifies that every successful render is parseable YAML, and a new etcd-extra-args case so the bug is caught by the existing test.

The original PR (#22575) addressing this is stale, so opening this as a replacement.

Diff

 etcd:
   local:
-    dataDir: /var/lib/minikube/etcd    extraArgs:
+    dataDir: /var/lib/minikube/etcd
+    extraArgs:
       - name: "listen-metrics-urls"
         value: "http://0.0.0.0:2381"

Fixes #21840

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: noamcohen97
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from medyagh May 26, 2026 14:37
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 26, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: noamcohen97 / name: Noam Cohen (b197243)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @noamcohen97!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 26, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @noamcohen97. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 26, 2026
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@noamcohen97 noamcohen97 force-pushed the fix-v1beta4-etcd-extraargs-newline branch from a81ff70 to b197243 Compare May 26, 2026 14:50
@noamcohen97
Copy link
Copy Markdown
Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing linebreak when providing etcd extraargs

3 participants