Fix --extra-config=etcd.* producing invalid kubeadm config#23051
Fix --extra-config=etcd.* producing invalid kubeadm config#23051noamcohen97 wants to merge 1 commit into
--extra-config=etcd.* producing invalid kubeadm config#23051Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: noamcohen97 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @noamcohen97! |
|
Hi @noamcohen97. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
a81ff70 to
b197243
Compare
|
/kind bug |
TestGenerateKubeadmYAMLnow verifies that every successful render is parseable YAML, and a newetcd-extra-argscase so the bug is caught by the existing test.The original PR (#22575) addressing this is stale, so opening this as a replacement.
Diff
Fixes #21840