golang: Build 1.25.0 images - take #2 (copy golang binaries from golang alpine image)#4119
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom Sep 16, 2025
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/M
dims
force-pushed
the
copy-golang-binaries-using-alpine-image
branch
6 times, most recently
from
11d10d8 to
dca886b
Compare
k8s-ci-robot
added
size/L
dims
force-pushed
the
copy-golang-binaries-using-alpine-image
branch
8 times, most recently
from
7e6177a to
32c6bd0
Compare
dims
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/kind feature |
k8s-ci-robot
added
kind/feature
saschagrunert
approved these changes
Sep 15, 2025
Member
saschagrunert
left a comment
saschagrunert
left a comment
There was a problem hiding this comment.
LGTM, PTAL @cpanato
/hold
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
Member
Author
|
@saschagrunert not sure if @cpanato is around this week per his last comment in the related PR: |
Co-Authored-by: Carlos Panato <ctadeu@gmail.com> [WIP] Copy golang binaries using alpine image
dims
force-pushed
the
copy-golang-binaries-using-alpine-image
branch
from
581d66c to
2586f7e
Compare
k8s-ci-robot
removed
the
lgtm
Member
Author
|
Added some missing packages found using - https://github.com/kubernetes/kubernetes/pull/134073/files |
k8s-ci-robot
added
size/L
Member
Author
|
kube-cross is now working fine in kubernetes/kubernetes#134073 |
k8s-ci-robot
added
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
31 tasks
|
|
||
| - name: "registry.k8s.io/build-image/go-runner (go1.25-bookworm)" | ||
| version: v2.4.0-go1.25rc2-bookworm.0 | ||
| version: v2.4.0-go1.25.1-bookworm.0 |
Member
There was a problem hiding this comment.
@dims the image changes from this file needs to be promoted, do you want to take care of that?
Member
|
late /lgtm thanks |
BenTheElder
reviewed
Dec 11, 2025
| ENV PATH=/usr/local/go/bin:$PATH | ||
| ENV GOROOT=/usr/local/go | ||
| ENV GOLANG_VERSION=${GO_VERSION} | ||
| ENV GOTOOLCHAIN=local |
Member
There was a problem hiding this comment.
however, this also aligns with the golang image (which we use as a base) which also defaults to local ... :/
local means "always use my local version" ... which may defeat the .go-version logic
Member
There was a problem hiding this comment.
we have this issue in most of our golang: image based environments. sent #4215 to start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
As the dockerhub images for golang do not support exactly the versions of debian we use/need, we should just grab the binaries from one of the golang images (picked the alpine image) and use them in the versions of debian we want. See discussions:
We can't just move to newer debian as that has newer glibc which leads to other problems:
/hold
/assign @saschagrunert @ameukam @puerco @MadhavJivrajani
cc @kubernetes/release-managers @liggitt
Which issue(s) this PR fixes:
xref #3957
Special notes for your reviewer:
Does this PR introduce a user-facing change?
PS: used @cpanato 's PR #4094 as a starting point.