-
Notifications
You must be signed in to change notification settings - Fork 65
Replace host sensor with node agent sensing #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| tests | ||
| templates/node-agent-crds/README.md |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| ### CRDs location inside the chart tree | ||
| These CRDs are placed in the `templates/` directory instead of the standard `crds/` directory to allow Helm to manage their full lifecycle. | ||
| This ensures they are updated during `helm upgrade` and removed during `helm uninstall`, supporting the evolving sensing capabilities of the node-agent. | ||
| No need to install them before kubescape operator chart since they are about to be used only after node-agent is up and running. | ||
|
|
||
| ### tech debt | ||
| 1. move CRDs group from `kubescape.cloud` to `kubescape.io` | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| {{- $components := fromYaml (include "components" .) }} | ||
| {{- if $components.nodeAgent.enabled }} | ||
| {{- if .Values.nodeAgent.config.hostSensor.enabled }} | ||
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| name: cloudproviderinfos.hostdata.kubescape.cloud | ||
| spec: | ||
| group: hostdata.kubescape.cloud | ||
| names: | ||
| kind: CloudProviderInfo | ||
| listKind: CloudProviderInfoList | ||
| plural: cloudproviderinfos | ||
| singular: cloudproviderinfo | ||
| scope: Cluster | ||
| versions: | ||
| - name: v1beta1 | ||
| served: true | ||
| storage: true | ||
| schema: | ||
| openAPIV3Schema: | ||
| type: object | ||
| properties: | ||
| spec: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| status: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| additionalPrinterColumns: | ||
| - name: Node | ||
| type: string | ||
| jsonPath: .spec.nodeName | ||
| - name: Last Sensed | ||
| type: string | ||
| jsonPath: .status.lastSensed | ||
| {{- end }} | ||
| {{- end }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| {{- $components := fromYaml (include "components" .) }} | ||
| {{- if $components.nodeAgent.enabled }} | ||
| {{- if .Values.nodeAgent.config.hostSensor.enabled }} | ||
|
Comment on lines
+2
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid tying CRD lifecycle to At Line 3, disabling Proposed change {{- $components := fromYaml (include "components" .) }}
{{- if $components.nodeAgent.enabled }}
-{{- if .Values.nodeAgent.config.hostSensor.enabled }}
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
name: cniinfos.hostdata.kubescape.cloud
@@
-{{- end }}
{{- end }}Also applies to: 37-37 🤖 Prompt for AI Agents |
||
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| name: cniinfos.hostdata.kubescape.cloud | ||
| spec: | ||
| group: hostdata.kubescape.cloud | ||
| names: | ||
| kind: CNIInfo | ||
| listKind: CNIInfoList | ||
| plural: cniinfos | ||
| singular: cniinfo | ||
| scope: Cluster | ||
| versions: | ||
| - name: v1beta1 | ||
| served: true | ||
| storage: true | ||
| schema: | ||
| openAPIV3Schema: | ||
| type: object | ||
| properties: | ||
| spec: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| status: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| additionalPrinterColumns: | ||
| - name: Node | ||
| type: string | ||
| jsonPath: .spec.nodeName | ||
| - name: Last Sensed | ||
| type: string | ||
| jsonPath: .status.lastSensed | ||
| {{- end }} | ||
| {{- end }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| {{- $components := fromYaml (include "components" .) }} | ||
| {{- if $components.nodeAgent.enabled }} | ||
| {{- if .Values.nodeAgent.config.hostSensor.enabled }} | ||
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| name: controlplaneinfos.hostdata.kubescape.cloud | ||
| spec: | ||
| group: hostdata.kubescape.cloud | ||
| names: | ||
| kind: ControlPlaneInfo | ||
| listKind: ControlPlaneInfoList | ||
| plural: controlplaneinfos | ||
| singular: controlplaneinfo | ||
| scope: Cluster | ||
| versions: | ||
| - name: v1beta1 | ||
| served: true | ||
| storage: true | ||
| schema: | ||
| openAPIV3Schema: | ||
| type: object | ||
| properties: | ||
| spec: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| status: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| additionalPrinterColumns: | ||
| - name: Node | ||
| type: string | ||
| jsonPath: .spec.nodeName | ||
| - name: Last Sensed | ||
| type: string | ||
| jsonPath: .status.lastSensed | ||
| {{- end }} | ||
| {{- end }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| {{- $components := fromYaml (include "components" .) }} | ||
| {{- if $components.nodeAgent.enabled }} | ||
| {{- if .Values.nodeAgent.config.hostSensor.enabled }} | ||
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| name: kernelversions.hostdata.kubescape.cloud | ||
| spec: | ||
| group: hostdata.kubescape.cloud | ||
| names: | ||
| kind: KernelVersion | ||
| listKind: KernelVersionList | ||
| plural: kernelversions | ||
| singular: kernelversion | ||
| scope: Cluster | ||
| versions: | ||
| - name: v1beta1 | ||
| served: true | ||
| storage: true | ||
| schema: | ||
| openAPIV3Schema: | ||
| type: object | ||
| properties: | ||
| spec: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| status: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| additionalPrinterColumns: | ||
| - name: Node | ||
| type: string | ||
| jsonPath: .spec.nodeName | ||
| - name: Last Sensed | ||
| type: string | ||
| jsonPath: .status.lastSensed | ||
| {{- end }} | ||
| {{- end }} |
Uh oh!
There was an error while loading. Please reload this page.