Skip to content

feat: debug support msg and var#3058

Merged
ks-ci-bot merged 1 commit intokubesphere:mainfrom
redscholar:debug
Apr 3, 2026
Merged

feat: debug support msg and var#3058
ks-ci-bot merged 1 commit intokubesphere:mainfrom
redscholar:debug

Conversation

@redscholar
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

debug support msg and var

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow bot added release-note kind/feature Categorizes issue or PR as related to a new feature. labels Apr 3, 2026
@kubesphere-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the debug module by introducing a new var field for variable debugging and adding support for template filters within the msg field. The changes include updates to the core logic in pkg/modules/debug/debug.go, expanded documentation in both English and Chinese, and new test cases to verify the added functionality. The review feedback identifies critical issues regarding redundant JSON marshaling in the handleVarField and handleMsgField functions, which would result in unintended base64 encoding of data. Additionally, a suggestion was provided to improve formatOutput to correctly handle byte slices.

Signed-off-by: redscholar <blacktiledhouse@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 3, 2026

@redscholar redscholar added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2026
@ks-ci-bot ks-ci-bot merged commit 05471d0 into kubesphere:main Apr 3, 2026
7 checks passed
@redscholar redscholar deleted the debug branch April 3, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants