feat: debug support msg and var#3058
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redscholar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request enhances the debug module by introducing a new var field for variable debugging and adding support for template filters within the msg field. The changes include updates to the core logic in pkg/modules/debug/debug.go, expanded documentation in both English and Chinese, and new test cases to verify the added functionality. The review feedback identifies critical issues regarding redundant JSON marshaling in the handleVarField and handleMsgField functions, which would result in unintended base64 encoding of data. Additionally, a suggestion was provided to improve formatOutput to correctly handle byte slices.
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
|



What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: