Chore(deps):Removing non-existent dependency#920
Closed
Reetika2509 wants to merge 5 commits into
Closed
Conversation
Reetika2509
requested review from
FogDong,
barnettZQG,
chivalryq,
wangyikewxgm,
wonderflow and
yangsoon
as code owners
August 14, 2025 06:29
added 4 commits
August 14, 2025 15:10
Signed-off-by: Reetika Malhotra <rmalhotra@guidewire.com>
Signed-off-by: Reetika Malhotra <rmalhotra@guidewire.com>
Signed-off-by: Reetika Malhotra <rmalhotra@guidewire.com>
Signed-off-by: Reetika Malhotra <rmalhotra@guidewire.com>
Reetika2509
force-pushed
the
chore/dependency-upgrades
branch
from
August 14, 2025 09:40
333736d to
09e8ccb
Compare
Signed-off-by: Chaitanya Reddy Onteddu <co@guidewire.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the
VelaQLservice implementation to remove the dependency on the unavailablegithub.qkg1.top/kubevela/workflow/pkg/cue/packagespackage and theGetPackageDiscover()method. These changes ensure compatibility with the latest version of the KubeVela workflow module and resolve related build errors.Key Changes
github.com/kubevela/workflow/pkg/cue/packagesfrom affected files.velaQLServiceImplstruct to use an empty struct for thepdfield, eliminating the need forPackageDiscover.NewVelaQLServiceconstructor to initialize the empty struct.UnmarshalTomethod in theQueryViewfunction to follow Go best practices.Impact