Skip to content

Chore(deps):Removing non-existent dependency#920

Closed
Reetika2509 wants to merge 5 commits into
kubevela:mainfrom
semmet95:chore/dependency-upgrades
Closed

Chore(deps):Removing non-existent dependency#920
Reetika2509 wants to merge 5 commits into
kubevela:mainfrom
semmet95:chore/dependency-upgrades

Conversation

@Reetika2509

Copy link
Copy Markdown
Contributor

Summary

This pull request refactors the VelaQL service implementation to remove the dependency on the unavailable github.com/kubevela/workflow/pkg/cue/packages package and the GetPackageDiscover() method. These changes ensure compatibility with the latest version of the KubeVela workflow module and resolve related build errors.

Key Changes

  • Removed the import of github.com/kubevela/workflow/pkg/cue/packages from affected files.
  • Refactored the velaQLServiceImpl struct to use an empty struct for the pd field, eliminating the need for PackageDiscover.
  • Updated the NewVelaQLService constructor to initialize the empty struct.
  • Fixed error handling for the UnmarshalTo method in the QueryView function to follow Go best practices.
  • Cleaned up all references to the removed dependency and method.

Impact

  • Build Stability: Resolves build errors caused by missing packages in the latest KubeVela workflow module.
  • Code Maintainability: Reduces reliance on upstream dependencies, improving maintainability and future-proofing the service.
  • No API Changes: Does not alter the external API or user-facing functionality.

@Reetika2509 Reetika2509 changed the title Removing non-existent dependency Chore(deps):Removing non-existent dependency Aug 14, 2025
Reetika Malhotra added 4 commits August 14, 2025 15:10
Signed-off-by: Reetika Malhotra <rmalhotra@guidewire.com>
Signed-off-by: Reetika Malhotra <rmalhotra@guidewire.com>
Signed-off-by: Reetika Malhotra <rmalhotra@guidewire.com>
Signed-off-by: Reetika Malhotra <rmalhotra@guidewire.com>
@Reetika2509
Reetika2509 force-pushed the chore/dependency-upgrades branch from 333736d to 09e8ccb Compare August 14, 2025 09:40
Signed-off-by: Chaitanya Reddy Onteddu <co@guidewire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant