chore(kuma-dp): remove advertised address from dataplane object#15761
Open
tharun208 wants to merge 1 commit intokumahq:masterfrom
Open
chore(kuma-dp): remove advertised address from dataplane object#15761tharun208 wants to merge 1 commit intokumahq:masterfrom
tharun208 wants to merge 1 commit intokumahq:masterfrom
Conversation
eb4a07d to
43b6aa8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated networking.advertisedAddress field from the Dataplane API and updates xDS/topology codepaths, CLI output, and generated API docs/schemas accordingly to ensure dataplane addressing is based solely on networking.address.
Changes:
- Drop
advertisedAddressfromapi/mesh/v1alpha1/dataplane.protoand update generated Go/OpenAPI/JSON schema artifacts. - Update topology/xDS code to use
DataplaneIP/networking.addressand adjust affected unit tests. - Update
kumactldataplane table output to usenetworking.addressand tweak tool installation config inmise.toml.
Reviewed changes
Copilot reviewed 18 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/xds/topology/outbound.go | Switch endpoint selection from advertised IP to dataplane IP. |
| pkg/xds/topology/ingress_outbound_test.go | Update ingress outbound expectations to use address. |
| pkg/xds/topology/dataplanes_test.go | Update resolve-address tests to no longer assert advertised address. |
| pkg/xds/topology/dataplanes.go | Remove advertised-address resolution logic for dataplanes. |
| pkg/xds/sync/dataplane_watchdog.go | Stop including advertised address in Envoy Admin mTLS cert generation/caching. |
| pkg/xds/generator/inbound_proxy_generator_test.go | Update inbound interface fixtures after field removal. |
| pkg/plugins/policies/meshratelimit/plugin/v1alpha1/plugin_test.go | Update inbound interface fixtures after field removal. |
| pkg/core/xds/inspect/attachments_test.go | Update inbound interface helper after field removal. |
| pkg/core/resources/apis/mesh/dataplane_helpers.go | Remove advertised-address preference from GetIP() and from dataplane hash inputs. |
| pkg/core/permissions/matcher_test.go | Update matcher fixtures after inbound interface struct change. |
| mise.toml | Change hadolint tool source key to ubi:hadolint/hadolint. |
| docs/generated/raw/protos/DataplaneOverview.json | Remove advertisedAddress from generated DataplaneOverview schema docs. |
| docs/generated/raw/protos/Dataplane.json | Remove advertisedAddress from generated Dataplane schema docs. |
| docs/generated/openapi.yaml | Remove advertisedAddress from generated OpenAPI definitions. |
| app/kumactl/cmd/get/table_printer.go | Print dataplane address from networking.address. |
| api/mesh/v1alpha1/dataplaneoverview/schema.yaml | Remove advertisedAddress from DataplaneOverview API schema. |
| api/mesh/v1alpha1/dataplane_helpers_test.go | Update inbound interface expectations after field removal. |
| api/mesh/v1alpha1/dataplane_helpers.go | Remove DataplaneAdvertisedIP from InboundInterface and mapping logic. |
| api/mesh/v1alpha1/dataplane/rest.yaml | Remove advertisedAddress from Dataplane REST schema. |
| api/mesh/v1alpha1/dataplane.proto | Remove advertisedAddress field from Dataplane Networking message. |
| api/mesh/v1alpha1/dataplane.pb.go | Update generated protobuf Go types to reflect field removal. |
Contributor
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
0be5e7b to
ba64163
Compare
Signed-off-by: Tharun Rajendran <rajendrantharun@live.com>
ba64163 to
7ea8c24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned in the issue, this field does not affect the ingress, and hence, remove the advertised address from the dataplane object
Implementation information
networking.advertisedAddressfrom the dataplane objectSupporting documentation
Fix #15629