Skip to content

chore(kuma-dp): remove advertised address from dataplane object#15761

Open
tharun208 wants to merge 1 commit intokumahq:masterfrom
tharun208:chore/kuma_dp_remove_advertised_address
Open

chore(kuma-dp): remove advertised address from dataplane object#15761
tharun208 wants to merge 1 commit intokumahq:masterfrom
tharun208:chore/kuma_dp_remove_advertised_address

Conversation

@tharun208
Copy link
Copy Markdown
Contributor

Motivation

As mentioned in the issue, this field does not affect the ingress, and hence, remove the advertised address from the dataplane object

Implementation information

  1. Remove the networking.advertisedAddress from the dataplane object
  2. fix tests

Supporting documentation

Fix #15629

@tharun208 tharun208 requested a review from a team as a code owner March 5, 2026 21:48
@tharun208 tharun208 force-pushed the chore/kuma_dp_remove_advertised_address branch 2 times, most recently from eb4a07d to 43b6aa8 Compare March 5, 2026 21:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated networking.advertisedAddress field from the Dataplane API and updates xDS/topology codepaths, CLI output, and generated API docs/schemas accordingly to ensure dataplane addressing is based solely on networking.address.

Changes:

  • Drop advertisedAddress from api/mesh/v1alpha1/dataplane.proto and update generated Go/OpenAPI/JSON schema artifacts.
  • Update topology/xDS code to use DataplaneIP/networking.address and adjust affected unit tests.
  • Update kumactl dataplane table output to use networking.address and tweak tool installation config in mise.toml.

Reviewed changes

Copilot reviewed 18 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/xds/topology/outbound.go Switch endpoint selection from advertised IP to dataplane IP.
pkg/xds/topology/ingress_outbound_test.go Update ingress outbound expectations to use address.
pkg/xds/topology/dataplanes_test.go Update resolve-address tests to no longer assert advertised address.
pkg/xds/topology/dataplanes.go Remove advertised-address resolution logic for dataplanes.
pkg/xds/sync/dataplane_watchdog.go Stop including advertised address in Envoy Admin mTLS cert generation/caching.
pkg/xds/generator/inbound_proxy_generator_test.go Update inbound interface fixtures after field removal.
pkg/plugins/policies/meshratelimit/plugin/v1alpha1/plugin_test.go Update inbound interface fixtures after field removal.
pkg/core/xds/inspect/attachments_test.go Update inbound interface helper after field removal.
pkg/core/resources/apis/mesh/dataplane_helpers.go Remove advertised-address preference from GetIP() and from dataplane hash inputs.
pkg/core/permissions/matcher_test.go Update matcher fixtures after inbound interface struct change.
mise.toml Change hadolint tool source key to ubi:hadolint/hadolint.
docs/generated/raw/protos/DataplaneOverview.json Remove advertisedAddress from generated DataplaneOverview schema docs.
docs/generated/raw/protos/Dataplane.json Remove advertisedAddress from generated Dataplane schema docs.
docs/generated/openapi.yaml Remove advertisedAddress from generated OpenAPI definitions.
app/kumactl/cmd/get/table_printer.go Print dataplane address from networking.address.
api/mesh/v1alpha1/dataplaneoverview/schema.yaml Remove advertisedAddress from DataplaneOverview API schema.
api/mesh/v1alpha1/dataplane_helpers_test.go Update inbound interface expectations after field removal.
api/mesh/v1alpha1/dataplane_helpers.go Remove DataplaneAdvertisedIP from InboundInterface and mapping logic.
api/mesh/v1alpha1/dataplane/rest.yaml Remove advertisedAddress from Dataplane REST schema.
api/mesh/v1alpha1/dataplane.proto Remove advertisedAddress field from Dataplane Networking message.
api/mesh/v1alpha1/dataplane.pb.go Update generated protobuf Go types to reflect field removal.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2026

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@tharun208 tharun208 force-pushed the chore/kuma_dp_remove_advertised_address branch 2 times, most recently from 0be5e7b to ba64163 Compare March 5, 2026 21:58
Signed-off-by: Tharun Rajendran <rajendrantharun@live.com>
@tharun208 tharun208 force-pushed the chore/kuma_dp_remove_advertised_address branch from ba64163 to 7ea8c24 Compare March 7, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove networking.advertisedAddress from the Dataplane object

2 participants