build(make): harden target graph#15963
Draft
bartsmykla wants to merge 8 commits intokumahq:masterfrom
Draft
Conversation
Move parse-time side effects and hidden build steps into explicit GNU make prerequisites and file targets. Keep legacy target aliases and kubeconfig contracts working so existing local workflows still behave the same. Normalize the k3d deployment volume path for absolute `KUMA_DIR` worktree callers. Signed-off-by: Bart Smykla <bartek@smykla.com>
Contributor
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Contributor
|
I'm a little torn on that one. Do we have evidence of something not working in the makefile? The PR description mention "GNU make issues", where did we encounter these? Are they causing flakes in CI? |
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
WIP
Motivation
Fix the GNU make issues by making prerequisite edges explicit and by removing parse-time side effects from dev targets
Implementation information
KUMA_DIRcallers and keep existing local workflows working