Fix AudioDeviceManager destructor race on midiCallbackLock#115
Merged
Conversation
Copilot
AI
changed the title
Fix AudioDeviceManager destructor crash on shutdown (port of juce-framework/JUCE#1669)
Fix AudioDeviceManager destructor race on midiCallbackLock (port of juce-framework/JUCE#1669)
Jun 9, 2026
Copilot created this pull request from a session on behalf of
kunitoki
June 9, 2026 18:00
View session
kunitoki
approved these changes
Jun 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 78.49% 78.50% +0.01%
==========================================
Files 605 605
Lines 60548 60549 +1
==========================================
+ Hits 47525 47537 +12
+ Misses 13023 13012 -11
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
midiCallbackLockis declared afterenabledMidiInputsin the header, so it's destroyed first. A live MIDI input callback can then access the already-destroyedCriticalSection, causingEXCEPTION_ACCESS_VIOLATION_WRITEinRtlEnterCriticalSection.Change
yup_AudioDeviceManager.cpp: explicitly callenabledMidiInputs.clear()at the top of~AudioDeviceManager(), ensuring all MIDI inputs are torn down whilemidiCallbackLockis still valid.