Dockerized, added post-only limit orders to get maker fees instead of taker. by claytondukes · Pull Request #1 · kurt213/crypto-dca-bot

claytondukes · 2024-03-07T22:13:27Z

feat: post-only limit orders with fallback; docs and env updates

Modified to run in a docker container. Logs output to logs/dcabot.log
Enforce post_only on GTD/GTC limit orders; round to product increments and
validate product min sizes in bot/auth_coinbase.py
Add fallback-to-market after limit expiry (background thread) to guarantee
completion of scheduled buys
Normalize EC private key newlines and quotes; add COINBASE_VERBOSE flag for
optional SDK DEBUG logging; support TZ via .env
Update README to third-person style; document maker-first strategy
(percent-of-100 offsets) and timezone behavior; clarify schedule file usage
Add .env.example and schedule-sample.json (post_only + 600s timeout examples)
Rename docker-compose.yml -> compose.yml (Compose v2 default); update .gitignore
Remove schedule_template.json (replaced by schedule-sample.json)

…th 600s default

…count and 12h timeout

- Enforce post_only on GTD/GTC limit orders; round to product increments and validate product min sizes in [bot/auth_coinbase.py](bot/auth_coinbase.py) - Add fallback-to-market after limit expiry (background thread) to guarantee completion of scheduled buys - Normalize EC private key newlines and quotes; add COINBASE_VERBOSE flag for optional SDK DEBUG logging; support TZ via .env - Update README to document maker-first strategy, (percent-of-100 offsets) and timezone behavior; clarify schedule file usage - Add .env.example and schedule-sample.json (post_only + 600s timeout examples) - Rename docker-compose.yml -> compose.yml (Compose v2 default); update .gitignore - Remove schedule_template.json (replaced by schedule-sample.json)

feat: post-only limit orders with fallback; docs and env updates

Copilot

Pull Request Overview

Dockerize the app and migrate from CCXT to Coinbase Advanced Trade SDK, adding support for limit orders with optional maker-first logic and logging to a file.

Replace CCXT auth with Coinbase Advanced REST client and implement limit/market order placement with maker-first + fallback-to-market
Add Dockerfile and compose.yml to run the bot in a container and log to logs/dcabot.log
Provide a schedule sample file and expand README with setup, environment, and Docker instructions

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
main.py	Switch to auth_coinbase, pass order options from schedule, and schedule tasks
bot/auth_coinbase.py	New Coinbase Advanced Trade client with limit/market order logic and fallback thread
compose.yml	Docker Compose service to run the app and append logs to logs/dcabot.log
Dockerfile	Build Python image and install requirements
schedule-sample.json	New sample schedule with limit order config
schedule_template.json	Removed legacy template (now conflicts with README reference)
README.md	Major documentation update for features, setup, Docker usage, and scheduling
.env.example	Example env vars for Coinbase Advanced and TZ

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

README.md

bot/auth_coinbase.py

compose.yml

main.py

bot/auth_coinbase.py

Dockerfile

Updating per copilot pr feedback

Copilot

Pull Request Overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

bot/auth_coinbase.py

README.md

Copilot

Pull Request Overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

bot/auth_coinbase.py

main.py

…ord args for SDK calls

Copilot

Pull Request Overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 6 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

bot/auth_coinbase.py

README.md

main.py

Copilot

Pull Request Overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

main.py

bot/auth_coinbase.py

…fore market fallback

Copilot

Pull Request Overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

bot/scheduler.py

bot/auth_coinbase.py

claytondukes · 2025-10-17T21:20:38Z

Finally. Sheesh. I hate Copilot but I also respect and value it :)

…ptions - bot/auth_coinbase.py: - Extend create_order(...) to accept: - reprice_interval_seconds - reprice_duration_seconds - Start _reprice_and_fallback_worker(...) when repricing is enabled; otherwise fall back to the existing timed fallback worker. - Repricing behavior: - Poll current order; cancel; recompute remaining notional using Decimal. - Reprice limit to market × (1 - limit_price_pct/100), quantized by increments, post_only=true. - Repost GTD/short-slice limit repeatedly every interval until duration elapses. - Then execute safe fallback: cancel → poll terminal state (CANCELLED/EXPIRED/FILLED/REJECTED/FAILED) → recompute remainder → place market order for the remainder. - Add logs prefixed with "Reprice:" for repricing steps and final fallback. - Backward compatible: if reprice_interval_seconds is not set or 0, original single-limit + timed market fallback behavior is used. - main.py: - Read reprice_interval_seconds and reprice_duration_seconds from schedule items and pass them to create_order(...). Notes: - schedule.json is gitignored; not included in this commit. - Default behavior unchanged unless repricing fields are present in schedule.

de-dup statuses; init status - Introduce RepriceConfig dataclass to group repricing settings and timeout. - Replace long worker signatures with a single config object. - Add safe_float() helper and use it in fallback/reprice workers to remove repeated try/except for fv/fs/ap parsing. - Define TERMINAL_STATUSES on the class and reuse it across flows. - Initialize status explicitly (remove fragile `status in locals()` checks). - Wire create_order() success paths to construct config and start _start_reprice_or_fallback_thread(...). - Backward compatible: if reprice_interval_seconds is unset/0, use the original fallback-only worker.

…backs for durations/timeouts

…nly GTD logging; repair block and constants

… and post-only nudge helper; use in create_order

…sleeps to avoid tight loops

feat(repricing): add maker repricing before fallback; wire schedule options

- Add 'once' frequency to scheduler with self-canceling job - Implemented in [bot/scheduler.py::_set_once()](cci:1://file:///Users/cdukes/sourcecode/crypto-dca-bot/bot/scheduler.py:98:4-125:10) - Mapped in [scheduleSetup.create_schedule()](cci:1://file:///Users/cdukes/sourcecode/crypto-dca-bot/bot/scheduler.py:15:4-29:39) - Support absolute limit price and execution controls - [bot/auth_coinbase.py::create_order()](cci:1://file:///Users/cdukes/sourcecode/crypto-dca-bot/bot/auth_coinbase.py:170:4-564:13) now accepts: - `limit_price_absolute` (fixed price instead of percent discount) - `time_in_force` ("GTC" uses `limit_order_gtc`, else GTD with timeout) - `disable_fallback` (skips fallback thread and final market buy) - Extend [RepriceConfig](cci:2://file:///Users/cdukes/sourcecode/crypto-dca-bot/bot/auth_coinbase.py:45:0-52:34) with `disable_fallback` - [_start_reprice_or_fallback_thread()](cci:1://file:///Users/cdukes/sourcecode/crypto-dca-bot/bot/auth_coinbase.py:571:4-584:108) respects `disable_fallback` - [_build_reprice_config()](cci:1://file:///Users/cdukes/sourcecode/crypto-dca-bot/bot/auth_coinbase.py:586:4-605:9) propagates `disable_fallback` - Wire new fields from schedule to order creation - [main.py](cci:7://file:///Users/cdukes/sourcecode/crypto-dca-bot/main.py:0:0-0:0) reads `limit_price_absolute`, `time_in_force`, and `disable_fallback` and passes them to [create_order()](cci:1://file:///Users/cdukes/sourcecode/crypto-dca-bot/bot/auth_coinbase.py:170:4-564:13) Notes: - Existing percent-based repricing behavior remains unchanged. - Post-only handling and repricing safety clamps unaffected.

… safety - Execute 'once' schedules immediately if time has passed - Log cancellation errors instead of silently swallowing them - Warn when limit_price_absolute is >5% above market for buys - Honor disable_fallback in repricer to skip final market buy - Update README with new features and examples

- Remove unnecessary try-except around time_in_force conversion - Add missing 'Falling back to GTC' log message - Log exceptions in immediate-execution time check

- Tag 'once' jobs to prevent re-execution on bot restart - Remove unnecessary using_absolute flag, check limit_price_absolute directly - Fix time_in_force None check to use 'is not None' - Clarify time_in_force behavior in README (only GTC/GTD supported)

- Use .upper() directly on time_in_force without str() conversion - Clarify in README that non-GTC values default to GTD (no error)

- Use > instead of >= in time check to avoid duplicate execution - Log exception in absolute price validation instead of silent pass

- Use >= instead of > to handle edge case where current time matches scheduled time - Fallback log message was already in correct location (inside except block)

- Warn when limit_price_absolute >= market with post_only (will be rejected) - Include actual limit_price value in absolute mode log message - Keep existing >5% warning for non-post_only cases

feat(orders,scheduler), add 'once', GTC limit price

Change 'executed and cancelled' to 'completed and removed' to avoid confusion with order cancellation. The message refers to the schedule job being removed, not the order being cancelled.

fix: clarify 'once' schedule log message

claytondukes and others added 15 commits March 7, 2024 16:28

Dockerized

81de478

always restart container

20d8236

updated coinbase api

5b71555

.

1aa7cbb

feat: implement limit order support to reduce fees

80bb941

feat: implement limit order support to reduce fees

12be3e3

fix: use limit_order_gtc with end_time to prevent stuck orders

6a6e65d

fix: use limit_order_gtd with end_time to prevent stuck orders

a70c7aa

fix: use limit_order_gtd with end_time to prevent stuck orders

7e9a3ed

fix: round prices to 2 decimal places to fix precision error

c08e8f8

refactor: switch from order_timeout_hours to order_timeout_seconds wi…

8e131e4

…th 600s default

update: configure schedule template with limit orders using 0.01% dis…

9007bcf

…count and 12h timeout

docs: update README with correct default limit price percentage

cc7f955

Merge pull request #1 from claytondukes/feat/limit-orders

94ce222

feat: post-only limit orders with fallback; docs and env updates

Copilot AI review requested due to automatic review settings October 17, 2025 02:17

Copilot AI reviewed Oct 17, 2025

View reviewed changes

claytondukes and others added 2 commits October 16, 2025 22:30

Updating per copilot pr feedback

8c7e3f0

Merge pull request #2 from claytondukes/feat/limit-orders

c2cfe26

Updating per copilot pr feedback

claytondukes requested a review from Copilot October 17, 2025 02:42

Copilot AI reviewed Oct 17, 2025

View reviewed changes

bot/auth_coinbase.py Outdated Show resolved Hide resolved

bot/auth_coinbase.py Outdated Show resolved Hide resolved

bot/auth_coinbase.py Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

claytondukes added 2 commits October 16, 2025 22:48

fix: address copilot feedback - order message, logging config, cleanup

f8a4c39

Merge branch 'feat/limit-orders'

3ece2d4

claytondukes requested a review from Copilot October 17, 2025 02:51

Copilot AI reviewed Oct 17, 2025

View reviewed changes

bot/auth_coinbase.py Outdated Show resolved Hide resolved

bot/auth_coinbase.py Outdated Show resolved Hide resolved

bot/auth_coinbase.py Outdated Show resolved Hide resolved

bot/auth_coinbase.py Outdated Show resolved Hide resolved

main.py Outdated Show resolved Hide resolved

claytondukes changed the title ~~Dockerized~~ Dockerized, added post-only limit orders to get maker fees instead of taker. Oct 17, 2025

claytondukes added 2 commits October 16, 2025 22:57

fix: preserve Decimal precision for price/size calculations, use keyw…

0cf26ef

…ord args for SDK calls

Merge branch 'feat/limit-orders'

f31bbab

claytondukes requested a review from Copilot October 17, 2025 02:59

Copilot AI reviewed Oct 17, 2025

View reviewed changes

Merge branch 'feat/limit-orders'

a22c1b5

claytondukes requested a review from Copilot October 17, 2025 21:03

Copilot AI reviewed Oct 17, 2025

View reviewed changes

main.py Show resolved Hide resolved

bot/auth_coinbase.py Show resolved Hide resolved

claytondukes added 2 commits October 17, 2025 17:15

fix(orders): poll to terminal after cancel and recompute remaining be…

173c7a3

…fore market fallback

Merge branch 'feat/limit-orders'

cd8c881

claytondukes requested a review from Copilot October 17, 2025 21:16

Copilot AI reviewed Oct 17, 2025

View reviewed changes

bot/scheduler.py Show resolved Hide resolved

bot/auth_coinbase.py Outdated Show resolved Hide resolved

claytondukes and others added 22 commits October 18, 2025 21:44

fix(repricing): use RepriceConfig at all call sites; harden None fall…

c4094e2

…backs for durations/timeouts

fix(repricing): wait before first reprice; post-only nudge; success-o…

75a34a4

…nly GTD logging; repair block and constants

refactor(repricing): log refresh only on success; add error extractor…

4f227cf

… and post-only nudge helper; use in create_order

pr fix for decimal

baa25b1

pr fix for decimal

e7c22e0

style(repricing): use REPRICE_POLL_SLEEP for polling; clamp repricer …

5ec0c44

…sleeps to avoid tight loops

pr fix for decimal

6bfef7e

Merge pull request #3 from claytondukes/feat/reprice-before-fallback

c461235

feat(repricing): add maker repricing before fallback; wire schedule options

fix: improve exception handling and logging

c7d4d10

- Remove unnecessary try-except around time_in_force conversion - Add missing 'Falling back to GTC' log message - Log exceptions in immediate-execution time check

fix: improve time_in_force handling and documentation

98c0555

- Use .upper() directly on time_in_force without str() conversion - Clarify in README that non-GTC values default to GTD (no error)

fix: prevent duplicate execution and improve error visibility

8b0c085

- Use > instead of >= in time check to avoid duplicate execution - Log exception in absolute price validation instead of silent pass

fix: correct time comparison and log message placement

4e155e5

- Use >= instead of > to handle edge case where current time matches scheduled time - Fallback log message was already in correct location (inside except block)

fix: validate post_only absolute price and improve logging

aaabb3e

- Warn when limit_price_absolute >= market with post_only (will be rejected) - Include actual limit_price value in absolute mode log message - Keep existing >5% warning for non-post_only cases

Merge pull request #4 from claytondukes/feat/add-gtc-orders

dbaf57f

feat(orders,scheduler), add 'once', GTC limit price

fix: clarify 'once' schedule log message

e499b36

Change 'executed and cancelled' to 'completed and removed' to avoid confusion with order cancellation. The message refers to the schedule job being removed, not the order being cancelled.

Merge pull request #5 from claytondukes/feat/add-gtc-orders

e9ce608

fix: clarify 'once' schedule log message

updated gitignore

8ff105d

Conversation

claytondukes commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

claytondukes commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

claytondukes commented Mar 7, 2024 •

edited

Loading