fix(engine): self-heal enclave pool fill on transient failure (capped)#3155
Open
qu0b wants to merge 2 commits into
Open
fix(engine): self-heal enclave pool fill on transient failure (capped)#3155qu0b wants to merge 2 commits into
qu0b wants to merge 2 commits into
Conversation
On a failed fill the signal was consumed and dropped, so a transient error at startup (e.g. logs components not bootstrapped yet) could drain the pool to empty permanently. Re-queue the fill after a short backoff, up to maxFillRetries, then give up until the next fill signal; a successful fill resets the budget.
qu0b
force-pushed
the
qu0b/fix-enclave-pool-self-heal
branch
from
02613c9 to
59d4546
Compare
qu0b
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When an enclave-pool fill fails, re-queue it after a short backoff — up to a max retry count — instead of consuming the fill signal and dropping it.
Why
The pool's
runloop reads fill signals offfillChan. On a fill error it only logged andbreaked, so the signal was lost. If the initial fill (at engine startup) errored for a transient reason — e.g. the logs aggregator/collector aren't bootstrapped yet — the pool drained to empty and stayed empty permanently, forcing every enclave creation down the slow cold path.How
context.Canceledfill error, re-queue the same fill afterfillRetryBackoff(5s) via a non-blocking send, up tomaxFillRetries(5).