feat: KURTOSIS_IMAGE_ORG env var to override the org prefix of Kurtosis' own images#3157
Open
qu0b wants to merge 2 commits into
Open
feat: KURTOSIS_IMAGE_ORG env var to override the org prefix of Kurtosis' own images#3157qu0b wants to merge 2 commits into
qu0b wants to merge 2 commits into
Conversation
Adds an image_org helper + KURTOSIS_IMAGE_ORG env var that overrides the org/registry prefix of Kurtosis' own images (engine, core, files-artifacts-expander), defaulting to kurtosistech. The engine propagates the value to each API container so the override applies at every launch level. This lets operators run Kurtosis from images mirrored to / built under a private registry without code changes.
qu0b
force-pushed
the
qu0b/image-org-override
branch
from
3530654 to
5159721
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a small
image_orghelper and aKURTOSIS_IMAGE_ORGenvironment variable that overrides the org/registry prefix used for Kurtosis' own images —engine,core(API container), andfiles-artifacts-expander. It defaults tokurtosistech, so behavior is unchanged unless the var is set.Why
Today these prefixes are hardcoded (
kurtosistech/engine,kurtosistech/core,kurtosistech/files-artifacts-expander) — each with a// TODO This should come from the same logic that builds the server imagenote. Operators who mirror Kurtosis images into a private registry, or run images built under a different org, currently can't redirect them without patching the source.How
container-engine-lib/lib/image_orgwithGet()(returns$KURTOSIS_IMAGE_ORGor thekurtosistechdefault) and the exportedEnvVarName.image_org.Get() + "/" + <name> + ":" + versioninstead of the hardcoded literal.KURTOSIS_IMAGE_ORGinto the engine's env, and the API-container launcher propagates it into each API container's env — so the override cascades to images launched at every level.Default path is a no-op; only set the var to redirect.