feat(otel): Kubernetes backend for kurtosis otel start/stop#3158
Open
qu0b wants to merge 4 commits into
Open
Conversation
Mirrors docker_otel.go for k8s: deploys ClickHouse + otel-collector as in-cluster Deployments/Services/ConfigMaps (reusing the embedded init.sql + collector-bootstrap-config.yaml), idempotent by label, endpoints over cluster DNS. Wires the previously-stubbed Kubernetes case in shared.go's StartOtel/StopOtel. Pattern follows the existing kubernetes_grafloki.go CLI k8s observability stack.
…ollector->ClickHouse auth) Without CLICKHOUSE_DEFAULT_ACCESS_MANAGEMENT=1 the collector's export fails with code 516 (auth) connecting as default from another pod. Mirrors docker_otel.go. Validated e2e: enclave logs land in otel.otel_logs.
qu0b
force-pushed
the
qu0b/otel-k8s-backend
branch
from
d5bb00a to
3627413
Compare
…l.go Align const block (gofmt) and add //nolint:exhaustruct to the Kubernetes API struct literals (Container/EnvVar/ContainerPort/VolumeMount/Probe/ProbeHandler/ VolumeSource/ServicePort/Namespace), matching the existing cli/cli convention (see commands/lsp/kurtosis_extension.go). Refactored the inline-nested literals in ensureClickHouse/ensureCollector into named locals so each suppression attaches to its construct.
qu0b
force-pushed
the
qu0b/otel-k8s-backend
branch
from
3627413 to
80d515c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement the Kubernetes backend for the OTel stack (
StartOtelInK8s/StopOtelInK8s) and wire it into the existingStartOtel/StopOteldispatch.Follows up the recently-merged OTel CLI work (#3135, #3136), which added the
kurtosis otel start/stopcommands and the Docker backend but left Kubernetes returningunsupported cluster type.Why
On the Kubernetes backend,
kurtosis otel startpreviously errored out — the OTel ClickHouse + collector stack could only be brought up on Docker. This makes the same command work on k8s clusters.How
cli/cli/helpers/otel/kubernetes_otel.go: brings up the ClickHouse store and the OTel collector as Kubernetes resources and returns their endpoints (mirroring the Docker backend's behavior), plus the teardown path.shared.go: routeKurtosisClusterType_KubernetestoStartOtelInK8s/StopOtelInK8s(Podman stays unsupported).CLICKHOUSE_DB+DEFAULT_ACCESS_MANAGEMENTon the ClickHouse container so the collector authenticates against it.Docker and Podman paths are unchanged.