Update skills to match agent skills spec#3
Merged
mlieberman85 merged 6 commits intokusaridev:mainfrom Apr 7, 2026
Merged
Conversation
- Create scripts/lint.sh for local and CI shell script linting - Add .github/workflows/shellcheck.yml (triggers on push to main and PRs) - Fix ShellCheck issues in existing scripts (SC1091, SC2317, SC2329) - Exclude .specify/ framework scripts from analysis - Add --list flag to lint.sh for scope verification - Update README and CONTRIBUTING docs with lint instructions - Add feature spec, plan, and task artifacts for 003-shellcheck-ci Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Rename skill directories and update name fields to pass the agentskills.io spec validation (skills-ref validate). - Rename change-evaluate/ → kusari-change-evaluate/ - Rename change-fix/ → kusari-change-fix/ - Update SKILL.md name fields from dot-notation to kebab-case - Add compatibility field to both skills - Update all cross-references, docs, install.sh, and test paths - Both skills pass skills-ref validate with zero errors - All 38 existing tests pass Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # CLAUDE.md # tests/test-run-kusari-scan.sh # tests/test-sarif-parser.sh
The CI runner's ShellCheck version reports SC2317 (unreachable command) in addition to SC2329 (unused function) for trap-invoked functions. Disable both codes on the cleanup function. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
funnelfiasco
requested changes
Apr 7, 2026
Collaborator
funnelfiasco
left a comment
funnelfiasco
left a comment
There was a problem hiding this comment.
Looks good overall. My only blocker is resolving the uses: checkout pinning
.github/workflows/shellcheck.yml
Outdated
| shellcheck: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Collaborator
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 |
We should pin by hash. I'm not sure why v4 was specified here, since v6 is the most recent branch. If there's a reason we should use v4, then update the hash appropriately.
| description: "Run a Kusari security scan on the current repository. Scans code and dependencies against a git revision, presenting health score, code mitigations, and dependency mitigations. Use when the user asks for a security scan, vulnerability check, or wants to evaluate code changes for security issues." | ||
| allowed-tools: Read, Bash, Glob | ||
| license: apache-2.0 | ||
| compatibility: "Requires Kusari CLI v0.21.0+ or kusari-inspector MCP server. jq required for CLI fallback." |
Collaborator
There was a problem hiding this comment.
Should this be a higher version (e.g. the not-released 0.25.0)?
- Pin actions/checkout to hash (v6.0.2) per review feedback - Bump compatibility CLI version to v0.25.0+ for kebab-case skill names Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
funnelfiasco
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.