-
Notifications
You must be signed in to change notification settings - Fork 0
72 feature add nsupdate support #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
26f65de
feat: migrate xfr mod to dns mod
kweonminsung 434fbf4
feat: added nsupdate handler
kweonminsung 535eed9
chore: update README
kweonminsung 465826e
refactor: refactor dns mod acl handling
kweonminsung a83d76c
feat: migrate to tsig key based auth
kweonminsung 27076ab
refactor: migrate all logics to service mod
kweonminsung 0553188
Initial plan
Copilot 29f8f91
fix: improve NSUPDATE response, serial consistency, and TTL validation
Copilot 03d12c6
chore: edit comments
kweonminsung a682491
Merge pull request #75 from kweonminsung/copilot/sub-pr-73
kweonminsung 970e074
fix: enforce tsig key base64 format
kweonminsung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,25 @@ | ||
| listen_addr = "127.0.0.1" # Common listen address for all services | ||
| listen_addr = "127.0.0.1" # Common listen address for all services | ||
|
|
||
| [api] | ||
| listen_port = 3000 # HTTP API listen port | ||
| require_authentication = true # Enable API authentication (true/false) | ||
| listen_port = 3000 # HTTP API listen port | ||
| require_authentication = true # Enable API authentication (true/false) | ||
|
|
||
| [database] | ||
| type = "mysql" # Database type: mysql, sqlite, postgresql | ||
| type = "mysql" # Database type: mysql, sqlite, postgresql | ||
|
|
||
| [database.mysql] | ||
| server_url = "mysql://user:password@hostname:port/database" # Mysql server configuration | ||
|
|
||
| [database.sqlite] | ||
| file_path = "bindizr.db" # SQLite database file path | ||
| file_path = "bindizr.db" # SQLite database file path | ||
|
|
||
| [database.postgresql] | ||
| server_url = "postgresql://user:password@hostname:port/database" # PostgreSQL server configuration | ||
|
|
||
| [xfr] | ||
| listen_port = 53 # XFR server listen port (TCP) | ||
| secondary_addrs = "" # Comma-separated secondary DNS server addresses (e.g., "192.168.1.2:53,192.168.1.3:53") for NOTIFY | ||
| [dns] | ||
| listen_port = 53 # DNS server listen port (UDP and TCP) | ||
| secondary_addrs = "" # Comma-separated secondary DNS server addresses for NOTIFY (e.g., "192.168.1.2:53,192.168.1.3:53") | ||
| nsupdate_tsig_key = "" # Shared TSIG secret for nsupdate authentication (empty to disable, base64 recommended) | ||
|
|
||
| [logging] | ||
| log_level = "debug" # Log level: error, warn, info, debug, trace | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample config sets
nsupdate_tsig_key = ""(disables TSIG validation). Iflisten_addris ever changed off-loopback, this makes dynamic updates unauthenticated by default. Consider changing the shipped example to require a non-empty TSIG key (or clearly warning that leaving it empty enables unauthenticated updates) to avoid insecure deployments.