Skip to content

fix: fixed vertical alignment in Firefix browsers#135

Open
rastuhacode wants to merge 2 commits into
kyechan99:masterfrom
rastuhacode:fix/fix-alignment-for-zen
Open

fix: fixed vertical alignment in Firefix browsers#135
rastuhacode wants to merge 2 commits into
kyechan99:masterfrom
rastuhacode:fix/fix-alignment-for-zen

Conversation

@rastuhacode

Copy link
Copy Markdown
Contributor

Resolves #134

  1. Replaced alignment-baseline="middle" to dominant-baseline="middle"
  2. Updated snapshots and svg's
  3. Also updated venom.svg from the actual rendering (to remove stroke artifacts in example)

From the spec:

  • The dominant-baseline attribute specifies the dominant baseline, which is the baseline used to align the box's text and inline-level contents. It also indicates the default alignment baseline of any boxes participating in baseline alignment in the box's alignment context.
  • The alignment-baseline attribute specifies how an object is aligned with respect to its parent. This property specifies which baseline of this element is to be aligned with the corresponding baseline of the parent.

So while logically they are different, but visually, in current usage the dominant-baseline behaves the same as alignment-baseline on `text

Regression chance is minimal and I also checked all examples and it renders the same visually as before. But anyway double check is welcome!

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

@rastuhacode is attempting to deploy a commit to the kyechan99's projects Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.92%. Comparing base (5784863) to head (167e0fe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   92.87%   92.92%   +0.04%     
==========================================
  Files          28       28              
  Lines         449      452       +3     
  Branches      105      110       +5     
==========================================
+ Hits          417      420       +3     
  Misses         32       32              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Default vertical alignment doesn't work in Firefox browsers

2 participants