Fix sync issues with large post counts and max input vars#377
Open
benplum wants to merge 1 commit intokylephillips:masterfrom
Open
Fix sync issues with large post counts and max input vars#377benplum wants to merge 1 commit intokylephillips:masterfrom
benplum wants to merge 1 commit intokylephillips:masterfrom
Conversation
Contributor
|
Does this fix the same as PR 337 just in another way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix menu order issues on large page trees. If a server has a low
max_input_vars, or if a page tree is very large, the sync fails. This change will split the sync process into multiple ajax requests.I set the 'chunk' size to 200 as it seemed good in testing (high enough not to impact small-ish sites, but low enough to work on most servers).
I have tested the changes in production on large and small sites with different structures, but please let me know if you notice any issues.