fix AsyncDisposable usage erroring for older TypeScript versions. - #1507
Merged
igalklebanov merged 1 commit intoJul 17, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
igalklebanov
force-pushed
the
fix-old-typescript-support
branch
from
July 8, 2025 23:09
0e448cf to
50ab0ba
Compare
igalklebanov
force-pushed
the
fix-old-typescript-support
branch
from
July 8, 2025 23:19
5977612 to
50ab0ba
Compare
igalklebanov
changed the title
AsyncDisposable usage erroring for older TypeScript versions.
igalklebanov
commented
Jul 8, 2025
| const steps: string[] = [] | ||
|
|
||
| { | ||
| // @ts-ignore - `using` was only introduced in TS 5.2 |
Member
Author
There was a problem hiding this comment.
we're excluding the entire file from the older version typechecks via a CI script.
igalklebanov
commented
Jul 8, 2025
| @@ -1 +1,11 @@ | |||
| {"compilerOptions":{"target":"ES2022","lib":["ESNext"],"module":"CommonJS","outDir":"dist","skipLibCheck":true},"default":{"compilerOptions":{"target":"ES2022","lib":["ESNext"],"module":"CommonJS","outDir":"dist","skipLibCheck":true},"default":{"compilerOptions":{"target":"ES2022","lib":["ESNext"],"module":"CommonJS","outDir":"dist","skipLibCheck":true},"default":{"extends":"../../tsconfig-base.json","include":["src/**/*"],"compilerOptions":{"target":"ES2022","lib":["ESNext"],"module":"CommonJS","outDir":"dist","skipLibCheck":true}},"extends":"../../tsconfig-base.json","include":["src/**/*"],"exclude":["src/async-dispose.test.ts"]},"exclude":["src/async-dispose.test.ts"],"extends":"../../tsconfig-base.json","include":["src/**/*"]},"exclude":["src/async-dispose.test.ts","src/async-dispose.test.ts"],"extends":"../../tsconfig-base.json","include":["src/**/*"]} No newline at end of file | |||
... polyfill AsyncDisposable.
igalklebanov
force-pushed
the
fix-old-typescript-support
branch
from
July 10, 2025 00:57
a77a74e to
a1e45f6
Compare
igalklebanov
marked this pull request as ready for review
July 17, 2025 08:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
closes #1499.