Speed up SelectQueryBuilder.if type checking - #1965
Open
koskimas wants to merge 1 commit into
Open
Conversation
commit: |
|
⏱️ TypeScript Benchmark Results |
igalklebanov
reviewed
Aug 1, 2026
Comment on lines
+99
to
+117
| bench('kysely.updateTable(table).set(row)', () => { | ||
| return kysely.updateTable('my_table').set(row) | ||
| }).types([848, 'instantiations']) | ||
|
|
||
| bench('kysely.updateTable(table).set(column, value)', () => { | ||
| return kysely | ||
| .updateTable('my_table') | ||
| .set('my_table.col_2e66a5c7e24d1d066230f368ce8b094e', 'x') | ||
| }).types([3078, 'instantiations']) | ||
|
|
||
| bench('kysely.updateTable(table).set(eb => row)', () => { | ||
| return kysely.updateTable('my_table').set((eb) => ({ | ||
| col_1d726898491fbca9a8dac855d2be1be8: eb( | ||
| 'col_1d726898491fbca9a8dac855d2be1be8', | ||
| '+', | ||
| 1, | ||
| ), | ||
| })) | ||
| }).types([3520, 'instantiations']) |
Member
There was a problem hiding this comment.
these don't belong in this bench.
igalklebanov
reviewed
Aug 1, 2026
Comment on lines
+123
to
+125
| bench('kyselyAny.updateTable(table).set(row)', () => { | ||
| return kyselyAny.updateTable('my_table').set(row) | ||
| }).types([333, 'instantiations']) |
Member
There was a problem hiding this comment.
doesn't belong in this bench.
igalklebanov
reviewed
Aug 1, 2026
|
|
||
| console.log('if.bench.ts:\n') | ||
|
|
||
| bench.baseline(() => {}) |
Member
There was a problem hiding this comment.
it's probably better to:
Suggested change
| bench.baseline(() => {}) | |
| bench.baseline(() => { | |
| return kysely.selectFrom('my_table').select('my_table.id') | |
| }) |
igalklebanov
approved these changes
Aug 1, 2026
igalklebanov
left a comment
igalklebanov
left a comment
Member
There was a problem hiding this comment.
Hey 👋
Nice! 💪
How big of a -% change in insantiations?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Significantly speed up SelectQueryBuilder.if type checking.
It had kinda stupid types, that required a full SelectQueryBuilder comparison for each $if.
This PR also adds type benchmarks for various commonly used kysely queries.
This is on top of #1962.