Skip to content

aviv; vocab; promise and promise states#315

Merged
gelilaa merged 6 commits into
mainfrom
promise-vocab
Mar 10, 2022
Merged

aviv; vocab; promise and promise states#315
gelilaa merged 6 commits into
mainfrom
promise-vocab

Conversation

@aviv82

@aviv82 aviv82 commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

add promise and promise states

Checklists

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work
  • any embedded code snippets are formatted

@gelilaa gelilaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aviv82, it is really great that we can count on your vocabulary deliverables always 💚

@gelilaa gelilaa merged commit 6ec86b4 into main Mar 10, 2022
@gelilaa gelilaa deleted the promise-vocab branch March 10, 2022 11:44
@gelilaa gelilaa linked an issue Mar 10, 2022 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snippets: async and await vocabulary: promise and promise states

2 participants