[B5] Feature/watch memorize clean structure #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

revaerica wants to merge 21 commits into lab-kcks:main from joselinputri:feature/watch-memorize-clean-structure

Open

[B5] Feature/watch memorize clean structure #58

Remove unused SpeedSorting imports from App.tsx

Annotations

10 warnings

src/pages/group-sort/GroupSort.tsx#L827

React Hook useEffect has a missing dependency: 'startBackgroundMusic'. Either include it or remove the dependency array

src/pages/group-sort/GroupSort.tsx#L806

React Hook useEffect has missing dependencies: 'timeLeft' and 'timeUpSoundPlayed'. Either include them or remove the dependency array. You can also replace multiple useState variables with useReducer if 'setTimeLeft' needs the current value of 'timeUpSoundPlayed'

src/pages/flip-tiles/FlipTiles.tsx#L79

The ref value 'timeoutsRef.current' will likely have changed by the time this effect cleanup function runs. If this ref points to a node rendered by React, copy 'timeoutsRef.current' to a variable inside the effect, and use that variable in the cleanup function

src/pages/crosswords/index.tsx#L112

React Hook useEffect has a missing dependency: 'volume'. Either include it or remove the dependency array

src/pages/TypeTheAnswer.tsx#L154

React Hook useEffect has a missing dependency: 'submitGame'. Either include it or remove the dependency array

src/components/games/math-generator/MazeChase.tsx#L278

React Hook useEffect has a missing dependency: 'movePlayer'. Either include it or remove the dependency array

src/components/games/math-generator/MazeChase.tsx#L192

React Hook useEffect has a missing dependency: 'generateMaze'. Either include it or remove the dependency array

src/components/games/math-generator/FindTheMatch.tsx#L100

React Hook useEffect has missing dependencies: 'cards', 'moves', and 'score'. Either include them or remove the dependency array. You can also do a functional update 'setMoves(m => ...)' if you only need 'moves' in the 'setMoves' call

src/components/games/math-generator/BalloonPop.tsx#L57

React Hook useEffect has a missing dependency: 'colors'. Either include it or remove the dependency array

src/components/games/math-generator/BackgroundMusic.tsx#L41

React Hook useEffect has missing dependencies: 'autoPlay' and 'musicTracks'. Either include them or remove the dependency array

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[B5] Feature/watch memorize clean structure #58

Uh oh!

Uh oh!

[B5] Feature/watch memorize clean structure #58

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...

[B5] Feature/watch memorize clean structure #58

Are you sure you want to change the base?

Uh oh!

Remove unused SpeedSorting imports from App.tsx

Uh oh!

[B5] Feature/watch memorize clean structure #58

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...