Skip to content

feat(app-store): redesign App Store pages#289

Merged
zjy365 merged 10 commits into
labring:mainfrom
Che-Zhu:codex/app-store-redesign
May 22, 2026
Merged

feat(app-store): redesign App Store pages#289
zjy365 merged 10 commits into
labring:mainfrom
Che-Zhu:codex/app-store-redesign

Conversation

@Che-Zhu

@Che-Zhu Che-Zhu commented May 21, 2026

Copy link
Copy Markdown
Contributor

Redesign the App Store listing and detail pages to match the new Figma direction, including the dark hero, real app icons/screenshots, category tabs, search, sorting, pagination, FAQ styling, home-style footer, and redesigned template detail sections.

Use real app data from apps.json for screenshots, deploy counts, related templates, and deploy actions. Keep the existing shared Header/Footer flow and reuse pricing FAQ data.

Tested:

  • npm run lint
  • App Store list/detail utility and component tests
  • Browser check for /products/app-store/ and /en/products/app-store/eaglercraft-server/

@Che-Zhu Che-Zhu marked this pull request as ready for review May 21, 2026 17:42

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ef2075c21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +93 to +96
Ready-to-use,{' '}
<span className="whitespace-nowrap">
One-Click Deployment
</span>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore localized copy in App Store hero

The /[lang]/products/app-store page now renders fixed English marketing copy and search prompt in the hero, but this component has no lang-based translation path. On non-English routes (for example zh-cn), users will still see English text, which is a regression from the previous localized page content and makes the localized route inconsistent with its metadata/language URL.

Useful? React with 👍 / 👎.

className="mb-12 inline-flex items-center gap-2 text-xs text-zinc-500 transition hover:text-zinc-200 lg:mb-[92px]"
>
<ArrowLeft className="h-3.5 w-3.5" />
Back to templates

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Localize detail hero labels by active language

The detail hero uses hardcoded English UI strings (for example the back link and CTA text) even though this route is language-scoped (/[lang]/...). As a result, localized pages like zh-cn now show English labels on the primary detail surface, which regresses the previous language-aware behavior and breaks locale consistency for production users.

Useful? React with 👍 / 👎.

@zjy365 zjy365 merged commit 15cd173 into labring:main May 22, 2026
1 check passed
@Che-Zhu Che-Zhu deleted the codex/app-store-redesign branch May 22, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants