Use curated READMEs for app store detail pages#290
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d0a02eb92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const readmeUrl = app.readme || undefined; | ||
| if (readmeUrl) { | ||
| const directSource = buildDirectReadmeSource(readmeUrl); | ||
| if (directSource) return directSource; | ||
| } |
There was a problem hiding this comment.
Fall back to GitHub source when configured README fails
This change makes app.readme authoritative: if the URL parses, getReadmeSource returns it immediately and loadReadmeMarkdown later converts any fetch failure into null, so the statically generated page permanently renders the screenshot fallback for that app build. In the app-store detail flow (page.tsx + loadReadmeMarkdown), a typo/404/transient outage on the configured README URL now suppresses the previously available GitHub/website candidate resolution path instead of falling back to it.
Useful? React with 👍 / 👎.
Summary
readmeURL field to generated app store app configsTest Plan
/en/products/app-store/eaglercraft-server/