Skip to content

Use curated READMEs for app store detail pages#290

Merged
zjy365 merged 6 commits into
labring:mainfrom
Che-Zhu:codex/app-store-updates
May 24, 2026
Merged

Use curated READMEs for app store detail pages#290
zjy365 merged 6 commits into
labring:mainfrom
Che-Zhu:codex/app-store-updates

Conversation

@Che-Zhu

@Che-Zhu Che-Zhu commented May 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a readme URL field to generated app store app configs
  • use curated README content written for each app instead of deriving the README from the upstream project repository
  • preload that README markdown during static page generation and render it directly in the detail page
  • remove the old README source metadata row from the detail page preview

Test Plan

  • npm run lint
  • node scripts/generate-apps-api.test.mjs
  • npx tsx 'app/[lang]/products/app-store/[slug]/components/figma-gradient-heading.test.mts'
  • production build/start manual verification of the app store list and /en/products/app-store/eaglercraft-server/

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d0a02eb92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +203 to +207
const readmeUrl = app.readme || undefined;
if (readmeUrl) {
const directSource = buildDirectReadmeSource(readmeUrl);
if (directSource) return directSource;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fall back to GitHub source when configured README fails

This change makes app.readme authoritative: if the URL parses, getReadmeSource returns it immediately and loadReadmeMarkdown later converts any fetch failure into null, so the statically generated page permanently renders the screenshot fallback for that app build. In the app-store detail flow (page.tsx + loadReadmeMarkdown), a typo/404/transient outage on the configured README URL now suppresses the previously available GitHub/website candidate resolution path instead of falling back to it.

Useful? React with 👍 / 👎.

@Che-Zhu Che-Zhu changed the title Preload app store READMEs at build time Use curated READMEs for app store detail pages May 23, 2026
@zjy365 zjy365 merged commit 94996ad into labring:main May 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants