fix(objectstorage): tighten public read bucket policy

[nowinkeyy]

No description provided.

[dinoallo]

ListBucket should also be disabled in PublicReadWrite

[Copilot]

Pull request overview

This PR tightens the generated S3 bucket policies for “public” buckets in the objectstorage controller, primarily removing anonymous bucket-list/location permissions while adding/adjusting policy tests to prevent regressions.

Changes:

• Restrict PublicReadBucketPolicy and PublicReadwriteBucketPolicy to avoid anonymous bucket listing/location actions (keep object-level actions only).
• Refactor BucketServiceAccountPolicy statements to separate bucket-level vs object-level resources/actions more cleanly.
• Add unit tests for buildPolicy(...) to validate the intended action/resource split and the tightened public policies.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
controllers/objectstorage/main.go	Import/flag formatting changes; introduces an unused CLI flag and removes kubebuilder scaffold marker.
controllers/objectstorage/controllers/suite_test.go	Test file import/var formatting; removes kubebuilder scaffold marker.
controllers/objectstorage/controllers/objectstorageuser_controller.go	Mostly formatting and minor error/string conversion adjustments.
controllers/objectstorage/controllers/objectstoragebucket_controller.go	Tightens public bucket policy generation and refactors service account policy statements.
controllers/objectstorage/controllers/objectstoragebucket_controller_test.go	Adds unit tests covering policy JSON and action/resource expectations.