Refactor UI#2
Open
pagreene wants to merge 28 commits into
Open
Conversation
BUG NOTE: for some an unknown reason, OSDViewer isn't working.
NOTE: There is a bug where the navbars are being bumped off the page, for an unknown reason.
This was a bug that resulted from the image element height being hard-coded. It was fixed by leaning into the use of flex-boxes. See here for details: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Flexible_Box_Layout/Basic_Concepts_of_Flexbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR heavily refactors the Minerva UI, fully committing to using React-Bootstrap (and upgrading to bootstrap 5), and implementing a layered, github-like interface for browsing repos and images. The UI is now works well on both a computer and mobile device. Some instabilities were also fixed.
Behind the scenes, the component hierarchy was simplified to separate the different levels of navigation.