Skip to content

Use itemlist component#210

Draft
gygabor wants to merge 15 commits into
mainfrom
use-itemlist-component
Draft

Use itemlist component#210
gygabor wants to merge 15 commits into
mainfrom
use-itemlist-component

Conversation

@gygabor

@gygabor gygabor commented Dec 29, 2021

Copy link
Copy Markdown
Collaborator

No description provided.

@baxgas

baxgas commented Dec 29, 2021

Copy link
Copy Markdown
Collaborator

Thanks @gygabor
I have a few remarks,

  • why isn't there a Show description on the Shows listing page?
  • you use the white border hover style on the Shows and News pages, but not on Archives, shouldn't it be the same everywhere? also the number of the items per row and the title/type style should be the same, no?
  • I don't like that the white border hover sticks to the edge of the viewport (left-edge for the first, right-edge for the last in the row), there should be a bit (larger) margin around the container

@gygabor

gygabor commented Dec 29, 2021

Copy link
Copy Markdown
Collaborator Author

Thanks @gygabor I have a few remarks,

  • why isn't there a Show description on the Shows listing page?

Because the descriptions on ananasz are also missing.

  • you use the white border hover style on the Shows and News pages, but not on Archives, shouldn't it be the same everywhere? also the number of the items per row and the title/type style should be the same, no?

Because I didn't update the archive page yet.

  • I don't like that the white border hover sticks to the edge of the viewport (left-edge for the first, right-edge for the last in the row), there should be a bit (larger) margin around the container

You're right. Something happened. I'll fix it.

@baxgas

baxgas commented Dec 30, 2021 via email

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants