Separate show queries towards Arcsi by tuz666 · Pull Request #325 · lahmacunradio/frontend

tuz666 · 2026-05-17T16:37:33Z

The radio website currently uses the /all_without_items for each show related queries
- The usage of this endpoint is entirely removed from the code base
As our plan is to extend the schedule with bi-weekly and monthly shows and our intention is to handle this feature on the backend side it is required to separate these incoming requests
There should be at least two show related endpoints used by the website, one which returns the strictly schedule related additional fields (week, day, start, end, frequency, later on filtered according to the given week), and another one which returns all the shows with way less fields.
- The new /all_schedule and /all_tiles endpoints are used for these purposes
Some ambiguous namings were also clarififed to make the code cleaner and more readable

…d schedule endpoints

pvj

I have one recommendation but even that is just optimisation. So in general good job and I approve. Thank you!

pvj · 2026-05-21T10:43:09Z

 <template>
  <div v-if="episode" class="latest-arcsi-blokk">
-    <NuxtLink :to="`/shows/${showslug}/${episodeLink}`" class="episode-block relative block w-full mb-2 bg-white">
+    <NuxtLink :to="`/shows/${showSlug}/${episodeSlug}`" class="episode-block relative block w-full mb-2 bg-white">


pvj · 2026-05-21T10:47:54Z

-      }
-      return null
+    arcsiEpisodesSliced () {
+      return this.arcsiEpisodes.slice(this.startIndex, this.numberOfEpisodes)


👍

The backend can't send anything not archived or without a name_slug right?

pvj · 2026-05-21T10:51:30Z

+      // refresh arcsiShowsForTiles every 10 minutes
      if (minutes % 10 === 0) {
-        this.refreshAllShows()
+        this.refreshArcsiShowsForTiles()


Question about tiles: Is it only going to change when we add new shows or also whenever a new episode is published?

Anyway I think schedule 10 min is okay but hopefully we can be more relaxed about shows tiles after this split, what do you think?

baxgas · 2026-06-24T10:10:05Z

            </div>

-            <div v-if="arcsiShow" class="show-infos">
+            <div v-if="this.arcsiShow" class="show-infos">


this. nem kell a templaten belül, elég csak arcsiShow (pl. máshol is
)

Kosz a commenteket @baxgas !!

baxgas · 2026-06-24T10:11:37Z

+      }
+
+      // refresh arcsiShowsForSchedule every 10 minutes
+      if (minutes % 10 === 0) {


a két if (minutes % 10 === 0) ugyanaz, össze lehet vonni és egy blokkon belül menjen a két call?

baxgas · 2026-06-24T10:13:38Z

-          .slice(this.startIndex, this.numberOfEpisodes)
-      }
-      return null
+    arcsiEpisodesSliced () {


lehet érdemes be rakni guardot, mint ahogy volt if (this.arcsiEpisodes) {...} return null vagy if (!this.arcsiEpisodes) return null

baxgas · 2026-06-24T10:15:29Z

  computed: {
    episodeImage() {
-      return this.episode.image_url.length > 0 ? this.episode.image_url : this.arcsilist.find(item => item.id === this.episode.shows[0].id).cover_image_url
+      return this.episode.image_url.length > 0 ? this.episode.image_url : this.showList.find(show => show.id === this.episode.shows[0].id).cover_image_url


ide is érdemes rakni guardot (? a pont elé) find(...)?.cover_image_url hogy ne törjön az egész ha esetleg nem talál matchet és le akarja kérdezni a keyt az undefined-ből

baxgas · 2026-06-24T10:16:30Z

  },
  created() {
-    this.showslug = this.arcsilist.find(item => item.id === this.episode.shows[0].id).archive_lahmastore_base_url
+    this.showSlug = this.showList.find(show => show.id === this.episode.shows[0].id).archive_lahmastore_base_url


ide is érdemes rakni guardot find(...)?.archive_lahmastore_base_url hogy ne törjön az egész ha esetleg nem talál matchet és le akarja kérdezni a keyt az undefined-ből

baxgas · 2026-06-24T10:18:02Z

  computed: {
    episodeImage() {
-      return this.episode.image_url.length > 0 ? this.episode.image_url : this.arcsilist.find(item => item.id === this.episode.shows[0].id).cover_image_url
+      return this.episode.image_url.length > 0 ? this.episode.image_url : this.showList.find(show => show.id === this.episode.shows[0].id).cover_image_url


ide is érdemes rakni guardot (? a pont elé) find(...)?.cover_image_url hogy ne törjön az egész ha esetleg nem talál matchet és le akarja kérdezni a keyt az undefined-ből

baxgas · 2026-06-24T10:18:40Z

  },
  created() {
-    this.showslug = this.arcsilist.find(item => item.id === this.episode.shows[0].id).archive_lahmastore_base_url
+    this.showSlug = this.showList.find(show => show.id === this.episode.shows[0].id).archive_lahmastore_base_url


ide is érdemes rakni guardot (? a pont elé) find(...)?.archive_lahmastore_base_url hogy ne törjön az egész ha esetleg nem talál matchet és le akarja kérdezni a keyt az undefined-ből

baxgas · 2026-06-24T10:22:00Z

      <div v-if="defaultArcsiShows" class="mb-8">
        <AutoCompleteSearch
-          :default-items="defaultArcsiShows"
+          :defaultShows="defaultArcsiShows"


a vue-ban kebab-case kell a komponensek bindingjaira :default-shows="defaultArcsiShows" (régi is default-items volt)

baxgas · 2026-06-24T10:23:54Z

-Node version `=14.18.2`
+Node version `=14.21.3`

 Node Version Manager (.nvmrc) has 14.18.2 as recommended, run `nvm install` and `nvm use` in `app` folder


valóban, itt el lett felejtve frissíteni a readme-t az .nvmrc aktuális állapotáról, köszi! viszont akkor ebben a sorban is frissíteni kellene

tuz666 added 4 commits May 13, 2026 22:38

new endpoints for show tiles and schedule, cleanup RadioPlayer

27e3a09

cleanup tag subpage

5a1f6f3

Remove the usage of shows/all_without_items, replace it with tiles an…

305c6d3

…d schedule endpoints

Fix tag/<clean_name> site

6532104

tuz666 marked this pull request as draft May 18, 2026 16:37

tuz666 added 2 commits May 18, 2026 20:02

Cleanup mediabaseurl

f93e3da

Fix image URLs

6a10a56

tuz666 requested review from baxgas, gammaw and pvj May 18, 2026 23:17

Remove frontend-side filtering

d66ebad

tuz666 marked this pull request as ready for review May 19, 2026 15:08

tuz666 added 3 commits May 19, 2026 17:36

Use new dedicated tag endpoint

651f202

Clarify if items are episodes or shows

8dc7bcb

Fix Schedule page

d1b07d1

pvj previously approved these changes May 21, 2026

View reviewed changes

Align to latest arcsi changes

096fd24

tuz666 dismissed pvj’s stale review via 096fd24 June 20, 2026 22:37

tuz666 added 2 commits June 21, 2026 00:51

Fix

d3788a8

fixx

6b04333

baxgas requested changes Jun 24, 2026

View reviewed changes

Address comments

94d075f

Uh oh!

Conversation

tuz666 commented May 17, 2026

Uh oh!

pvj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants