test(aws): Make integration test cassettes AWS region agnostic#1156
Open
Michael Chin (michaelnchin) wants to merge 1 commit into
Open
test(aws): Make integration test cassettes AWS region agnostic#1156Michael Chin (michaelnchin) wants to merge 1 commit into
Michael Chin (michaelnchin) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing some cassette errors seen in live integ test runs following the updates in #1154:
Basically, the new cassettes for the revised tests with Sonnet 5 were recorded from my local runs on
us-west-2, while the CI actually runs on a different region (that's obfuscated by theAWS_REGIONsecret). VCR's default matcher requires the endpoint URIs to match exactly, so the replays fail.To fix this, I've loosened the URI check by replacing VCR's default matcher with a custom
region_agnostic_urimatcher, stripping the region ID from the host before performing the comparison.This has two advantages:
AWS_REGIONwithout having to update the cassettes to do so.