fix: preserve parallel connector runs and state - #552
Open
Gautam Sharma (GautamSharma99) wants to merge 1 commit into
Open
fix: preserve parallel connector runs and state#552Gautam Sharma (GautamSharma99) wants to merge 1 commit into
Gautam Sharma (GautamSharma99) wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 2d8ca45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #542.
Connector run IDs previously used only an ISO timestamp, so calls in the same millisecond shared raw-data directories and fixed filenames. MCP operations also read connector state before network work and later replaced the whole document from that stale snapshot, dropping parallel run history.
Changes
updateConnectorState, a process-local FIFO transaction per connector that re-reads state immediately before applying an updater and committing it.state.json.Why this fixes the race
Each invocation now owns a unique raw directory, so
mcp-tools.jsonandmcp-tool-result.jsoncannot replace evidence from another invocation. MCP state commits are serialized per connector and each queued commit reads the latest file, so a later completion merges with the prior run instead of writing an old snapshot over it. Atomic replacement preserves the existing file until the new JSON is complete.Validation
pnpm run lint:checkpnpm run typecheckpnpm exec prettier --check(changed files)pnpm test— 68 files, 793 tests passed