fix: fail translation runs on filesystem discovery errors - #553
Open
Gautam Sharma (GautamSharma99) wants to merge 1 commit into
Open
fix: fail translation runs on filesystem discovery errors#553Gautam Sharma (GautamSharma99) wants to merge 1 commit into
Gautam Sharma (GautamSharma99) wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: efd2a08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #543.
Translation discovery previously converted every
backend.ls()error into an empty directory. During a language switch this could translate visible pages, skip an unreadable subtree, and let the run persist the target language while leaving the wiki mixed.Changes
/openwikiroot is genuinely absent (ENOENTor a not-found result); all nested missing directories remain failures because their contents are expected to exist after discovery.Why this fixes the data-integrity issue
An incomplete tree is no longer indistinguishable from an empty tree. Translation cannot silently finish with unknown pages, and the failed run does not reach language metadata persistence. A later retry will re-run discovery against the full tree rather than relying on per-page pending markers that could never be created for undiscovered files.
Validation
pnpm run lint:checkpnpm run typecheckpnpm exec prettier --check(changed files)pnpm test— 67 files, 793 tests passed