fix(ci): add missing SDK build step to cross-platform workflow_dispatch - #12536
Conversation
The build-if-needed job (used for workflow_dispatch) was not building the langflow-sdk package. Since lfx depends on langflow-sdk>=0.1.0 and langflow-sdk is not yet published to PyPI, all test jobs failed during lfx installation with 'No solution found'. Changes: - Build langflow-sdk wheel in build-if-needed job - Upload SDK artifact and output sdk-artifact-name - Update SDK download conditions with build-if-needed fallback - Update SDK+LFX combined/individual install conditions to properly route through the combined installer when both are available
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.9.0 #12536 +/- ##
=================================================
+ Coverage 50.00% 50.14% +0.14%
=================================================
Files 1930 1932 +2
Lines 171909 172044 +135
Branches 24071 25389 +1318
=================================================
+ Hits 85958 86269 +311
+ Misses 84905 84729 -176
Partials 1046 1046
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ch (#12536) The build-if-needed job (used for workflow_dispatch) was not building the langflow-sdk package. Since lfx depends on langflow-sdk>=0.1.0 and langflow-sdk is not yet published to PyPI, all test jobs failed during lfx installation with 'No solution found'. Changes: - Build langflow-sdk wheel in build-if-needed job - Upload SDK artifact and output sdk-artifact-name - Update SDK download conditions with build-if-needed fallback - Update SDK+LFX combined/individual install conditions to properly route through the combined installer when both are available
Problem: The build-if-needed job was not building the langflow-sdk package. Since lfx depends on langflow-sdk>=0.1.0 and it's not yet on PyPI, all test jobs fail during lfx installation with "No solution found".
Failing run: https://github.com/langflow-ai/langflow/actions/runs/24050788103
Fix (same pattern as #12524):
Build langflow-sdk wheel in build-if-needed (cd src/sdk && uv build --wheel)
Upload SDK artifact (adhoc-dist-sdk) and output sdk-artifact-name
Update all SDK download/install conditions with build-if-needed fallback
Fix routing so combined SDK+LFX installer triggers when both come from build-if-needed