Skip to content

fix(ci): add missing SDK build step to cross-platform workflow_dispatch - #12536

Merged
vjgit96 merged 1 commit into
release-1.9.0from
fix/cross-platform-sdk-build
Apr 6, 2026
Merged

fix(ci): add missing SDK build step to cross-platform workflow_dispatch#12536
vjgit96 merged 1 commit into
release-1.9.0from
fix/cross-platform-sdk-build

Conversation

@vjgit96

@vjgit96 vjgit96 commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Problem: The build-if-needed job was not building the langflow-sdk package. Since lfx depends on langflow-sdk>=0.1.0 and it's not yet on PyPI, all test jobs fail during lfx installation with "No solution found".

Failing run: https://github.com/langflow-ai/langflow/actions/runs/24050788103

Fix (same pattern as #12524):

Build langflow-sdk wheel in build-if-needed (cd src/sdk && uv build --wheel)
Upload SDK artifact (adhoc-dist-sdk) and output sdk-artifact-name
Update all SDK download/install conditions with build-if-needed fallback
Fix routing so combined SDK+LFX installer triggers when both come from build-if-needed

The build-if-needed job (used for workflow_dispatch) was not building
the langflow-sdk package. Since lfx depends on langflow-sdk>=0.1.0
and langflow-sdk is not yet published to PyPI, all test jobs failed
during lfx installation with 'No solution found'.

Changes:
- Build langflow-sdk wheel in build-if-needed job
- Upload SDK artifact and output sdk-artifact-name
- Update SDK download conditions with build-if-needed fallback
- Update SDK+LFX combined/individual install conditions to properly
  route through the combined installer when both are available
@coderabbitai

coderabbitai Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e14b9f22-1ec5-401c-a482-23e3081c14e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cross-platform-sdk-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vjgit96
vjgit96 requested a review from Adam-Aghili April 6, 2026 21:12
@github-actions github-actions Bot added the bug Something isn't working label Apr 6, 2026
@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Apr 6, 2026
@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.14%. Comparing base (f557b06) to head (1e74ecf).
⚠️ Report is 1 commits behind head on release-1.9.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.9.0   #12536      +/-   ##
=================================================
+ Coverage          50.00%   50.14%   +0.14%     
=================================================
  Files               1930     1932       +2     
  Lines             171909   172044     +135     
  Branches           24071    25389    +1318     
=================================================
+ Hits               85958    86269     +311     
+ Misses             84905    84729     -176     
  Partials            1046     1046              
Flag Coverage Δ
backend 55.92% <ø> (ø)
frontend 49.05% <ø> (+0.21%) ⬆️
lfx 49.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 186 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 29%
29.72% (31355/105494) 63.74% (3985/6251) 31.06% (732/2356)

Unit Test Results

Tests Skipped Failures Errors Time
3112 0 💤 0 ❌ 0 🔥 4m 59s ⏱️

@vjgit96
vjgit96 merged commit f8aa12d into release-1.9.0 Apr 6, 2026
95 of 96 checks passed
@vjgit96
vjgit96 deleted the fix/cross-platform-sdk-build branch April 6, 2026 21:29
Adam-Aghili pushed a commit that referenced this pull request Apr 15, 2026
…ch (#12536)

The build-if-needed job (used for workflow_dispatch) was not building
the langflow-sdk package. Since lfx depends on langflow-sdk>=0.1.0
and langflow-sdk is not yet published to PyPI, all test jobs failed
during lfx installation with 'No solution found'.

Changes:
- Build langflow-sdk wheel in build-if-needed job
- Upload SDK artifact and output sdk-artifact-name
- Update SDK download conditions with build-if-needed fallback
- Update SDK+LFX combined/individual install conditions to properly
  route through the combined installer when both are available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants