test: Refactor Playwright suite with shared helpers and remove redundant tests#13278
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 199 files, which is 49 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (199)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
test
Contributor
✅ Test Coverage AdvisorNo source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (51.72%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-1.10.0 #13278 +/- ##
==================================================
- Coverage 55.72% 55.43% -0.29%
==================================================
Files 2178 2178
Lines 205613 205599 -14
Branches 31091 31042 -49
==================================================
- Hits 114575 113980 -595
- Misses 89717 90301 +584
+ Partials 1321 1318 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Frontend Unit Test Coverage ReportCoverage Summary
Unit Test Results
|
olayinkaadelakun
approved these changes
May 22, 2026
viktoravelino
approved these changes
May 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 22, 2026
Cristhianzl
added a commit
that referenced
this pull request
May 22, 2026
…ntegration-clean Bring the Playwright suite refactor (PR #13278: shared helpers + centralized TID/TEXTS/TIMEOUTS constants) into the feature branch so our test fixes are standardized against it. Conflict resolutions (our fix kept, expressed in the refactored style): - await-bootstrap-test.ts / run-flow / actionsMainPage-shard-1 / bulk-actions: keep our race-safe openTemplatesModal() helper, adopt the refactor's expect().toBeVisible() assertion. - add-flow-to-test-on-empty-langflow.ts: keep both the TEXTS import and our explanatory doc comment. - generalBugs-shard-13: keep both import sets (openTemplatesModal + env/skip helpers). - general-bugs-shard-3909: keep our deletion of the broken add-project navigation block (awaitBootstrapTest already opens the modal). - folder-deletion-integrity / shareable-playground-persistence: take the refactor's version (it supersedes our small adjustments). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Cristhianzl
added a commit
that referenced
this pull request
May 22, 2026
PR #13278 (Playwright suite refactor) was squash-merged into release-1.10.0 as a single commit. Our branch already contains the exact same refactor — merged earlier from origin/cz/playwright-tests-refactor as its original commits — so git could not match the two and flagged re-conflicts across the test suite. The refactor content is byte-identical on both sides (verified: git diff between the refactor branch tip and the squashed commit is empty for src/frontend/tests). Every conflict was therefore resolved in favour of our side, which already carries the refactor PLUS our test fixes and the new-project-flow standardization. The resulting tree is byte-identical to HEAD (7f11ac5); this merge only records the squashed #13278 as a second parent so the branch shares ancestry with release-1.10.0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Restructure the Playwright e2e suite to remove duplication and dead code, and make UI-text/test-id changes a single-edit operation.
Changes
publish, sessions, env loading and skip guards
extracted into constants/texts.ts)